D21012: [PanelView] Update mask as last on resize event (& move one for consistency)
This revision was automatically updated to reflect the committed changes. Closed by commit R120:b51fd4bab2a5: [PanelView] Update mask as last on resize event ( move one for consistency) (authored by kossebau). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21012?vs=57540=57624 REVISION DETAIL https://phabricator.kde.org/D21012 AFFECTED FILES shell/panelview.cpp To: kossebau, #plasma, broulik Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D21012: [PanelView] Update mask as last on resize event (& move one for consistency)
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Makes sense and works fine, thanks REPOSITORY R120 Plasma Workspace BRANCH updatemasklast REVISION DETAIL https://phabricator.kde.org/D21012 To: kossebau, #plasma, broulik Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D21012: [PanelView] Update mask as last on resize event (& move one for consistency)
apol added a comment. That makes a lot of sense. +1 I'm not sure how to reproduce the issue but I've seen it happen many times. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21012 To: kossebau, #plasma, broulik Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D21012: [PanelView] Update mask as last on resize event (& move one for consistency)
kossebau added a comment. @broulik Could you tell if this improves the bug you found about "change resolution in plasma, the panel mask stays incorrect"? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21012 To: kossebau, #plasma, broulik Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D21012: [PanelView] Update mask as last on resize event (& move one for consistency)
kossebau created this revision. kossebau added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY The mask of a panel depends on things like borders set or window size, but nothing else on it. So it should be updated as last in the queue of things to update. There might be still state changes not properly propagated, but this is a move in the more expected direction. REPOSITORY R120 Plasma Workspace BRANCH updatemasklast REVISION DETAIL https://phabricator.kde.org/D21012 AFFECTED FILES shell/panelview.cpp To: kossebau, #plasma, broulik Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
