D21417: [ActionListItem] Make QML imports and tooltip consistent

[Björn Feber]

GB_2 updated this revision to Diff 58733.
GB_2 added a comment.


  Clean indentation

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21417?vs=58721=58733

BRANCH
  actionlistitem-make-qml-imports-and-tooltip-consistent (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21417

AFFECTED FILES
  discover/qml/ActionListItem.qml

To: GB_2, #plasma, #vdg, apol
Cc: apol, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21417: [ActionListItem] Make QML imports and tooltip consistent

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:7b778dbe90fe: [ActionListItem] Make QML imports and 
tooltip consistent (authored by GB_2).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21417?vs=58733=58735

REVISION DETAIL
  https://phabricator.kde.org/D21417

AFFECTED FILES
  discover/qml/ActionListItem.qml

To: GB_2, #plasma, #vdg, apol
Cc: apol, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21417: [ActionListItem] Make QML imports and tooltip consistent

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Otherwise it's good to go.

INLINE COMMENTS

> ActionListItem.qml:44
>  
> -ToolTip.visible: hovered
> -ToolTip.text: action.shortcut ? action.shortcut : p0.nativeText
> +readonly property var tooltip: QQC2.ToolTip {
> +text: action.shortcut ? action.shortcut : p0.nativeText

It has an indentation too much.

REPOSITORY
  R134 Discover Software Store

BRANCH
  actionlistitem-make-qml-imports-and-tooltip-consistent (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21417

To: GB_2, #plasma, #vdg, apol
Cc: apol, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21417: [ActionListItem] Make QML imports and tooltip consistent

[Björn Feber]

GB_2 updated this revision to Diff 58721.
GB_2 added a comment.


  Remove unneeded parent property

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21417?vs=58720=58721

BRANCH
  actionlistitem-make-qml-imports-and-tooltip-consistent (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21417

AFFECTED FILES
  discover/qml/ActionListItem.qml

To: GB_2, #plasma, #vdg
Cc: apol, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21417: [ActionListItem] Make QML imports and tooltip consistent

[Björn Feber]

GB_2 updated this revision to Diff 58720.
GB_2 added a comment.


  Remove workaround and put tooltip into property

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21417?vs=58689=58720

BRANCH
  actionlistitem-make-qml-imports-and-tooltip-consistent (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21417

AFFECTED FILES
  discover/qml/ActionListItem.qml

To: GB_2, #plasma, #vdg
Cc: apol, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21417: [ActionListItem] Make QML imports and tooltip consistent

[Aleix Pol Gonzalez]

apol added a comment.


  > Ok, weird. If I do it without the Control it shows this error: 
`qrc:/qml/ActionListItem.qml:44 Cannot assign object to list property 
"_basicDefault"`
  
  Try putting it into a property so that it's not assigned as the parent's 
default item.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D21417

To: GB_2, #plasma, #vdg
Cc: apol, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21417: [ActionListItem] Make QML imports and tooltip consistent

[Björn Feber]

GB_2 added a comment.


  In D21417#470381 , @apol wrote:
  
  > But BasicListItem already is a Control.
  >  https://doc.qt.io/qt-5/qml-qtquick-controls2-itemdelegate.html
  
  
  Ok, weird. If I do it without the Control it shows this error: 
`qrc:/qml/ActionListItem.qml:44 Cannot assign object to list property 
"_basicDefault"`

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D21417

To: GB_2, #plasma, #vdg
Cc: apol, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21417: [ActionListItem] Make QML imports and tooltip consistent

[Aleix Pol Gonzalez]

apol added a comment.


  But BasicListItem already is a Control.
  https://doc.qt.io/qt-5/qml-qtquick-controls2-itemdelegate.html

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D21417

To: GB_2, #plasma, #vdg
Cc: apol, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21417: [ActionListItem] Make QML imports and tooltip consistent

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  T10862  and T10873 


TEST PLAN
  The tooltip now behaves correctly.

REPOSITORY
  R134 Discover Software Store

BRANCH
  actionlistitem-make-qml-imports-and-tooltip-consistent (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21417

AFFECTED FILES
  discover/qml/ActionListItem.qml

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart