D21434: [Notifications KCM] Try both model indices

2019-05-28 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:85359e1d4b22: [Notifications KCM] Try both model indices 
(authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21434?vs=58737=58749

REVISION DETAIL
  https://phabricator.kde.org/D21434

AFFECTED FILES
  kcms/notifications/package/contents/ui/SourcesPage.qml

To: broulik, #plasma, nicolasfella, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D21434: [Notifications KCM] Try both model indices

2019-05-27 Thread Nicolas Fella
nicolasfella added a comment.


  Works for me
  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21434

To: broulik, #plasma, nicolasfella
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D21434: [Notifications KCM] Try both model indices

2019-05-27 Thread Kai Uwe Broulik
broulik created this revision.
broulik added reviewers: Plasma, nicolasfella.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  We prefer applicatons over services, however, when configuring a KDE 
application we get passed both an application and a service. That application 
might be `NoDisplay` and then we end up not finding an index and event 
configuration files.

TEST PLAN
  5.16 branch
  
  I can now configure KDE Connect notifications by clicking the configure icon 
on the notification.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21434

AFFECTED FILES
  kcms/notifications/package/contents/ui/SourcesPage.qml

To: broulik, #plasma, nicolasfella
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart