D21435: [ActionTextField] Make QML tooltip consistent

2019-05-30 Thread Björn Feber 
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:e5bf8cff95c7: [ActionTextField] Make QML tooltip 
consistent (authored by GB_2).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21435?vs=58738=58916

REVISION DETAIL
  https://phabricator.kde.org/D21435

AFFECTED FILES
  src/controls/ActionTextField.qml

To: GB_2, #plasma, #vdg, #kirigami, ngraham, mart
Cc: ngraham, mart, ognarb, #vdg, plasma-devel, #plasma, domson, dkardarakos, 
apol, davidedmundson, hein

D21435: [ActionTextField] Make QML tooltip consistent

2019-05-30 Thread Björn Feber 
GB_2 added a comment.


  @mart Can I land this?

REPOSITORY
  R169 Kirigami

BRANCH
  actiontextfield-make-qml-tooltip-consistent (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21435

To: GB_2, #plasma, #vdg, #kirigami, ngraham
Cc: ngraham, mart, ognarb, #vdg, plasma-devel, #plasma, domson, dkardarakos, 
apol, davidedmundson, hein

D21435: [ActionTextField] Make QML tooltip consistent

2019-05-27 Thread Nathaniel Graham 
ngraham added a comment.


  Argh, I explicitly did NOT accept as Kirigami but Phab did it anyway. :(

REPOSITORY
  R169 Kirigami

BRANCH
  actiontextfield-make-qml-tooltip-consistent (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21435

To: GB_2, #plasma, #vdg, #kirigami, ngraham
Cc: ngraham, mart, ognarb, #vdg, plasma-devel, #plasma, domson, dkardarakos, 
apol, davidedmundson, hein

D21435: [ActionTextField] Make QML tooltip consistent

2019-05-27 Thread Nathaniel Graham 
ngraham added subscribers: mart, ngraham.
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  @mart?

REPOSITORY
  R169 Kirigami

BRANCH
  actiontextfield-make-qml-tooltip-consistent (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21435

To: GB_2, #plasma, #vdg, #kirigami, ngraham
Cc: ngraham, mart, ognarb, #vdg, plasma-devel, #plasma, domson, dkardarakos, 
apol, davidedmundson, hein

D21435: [ActionTextField] Make QML tooltip consistent

2019-05-27 Thread Carl Schwan 
ognarb added a reviewer: Kirigami.
ognarb added a comment.


  +1

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D21435

To: GB_2, #plasma, #vdg, #kirigami
Cc: ognarb, #vdg, plasma-devel, #plasma, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D21435: [ActionTextField] Make QML tooltip consistent

2019-05-27 Thread Björn Feber 
GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  T10873 

TEST PLAN
  Hover over for example the Discover search bar. The tooltip now behaves 
correctly.

REPOSITORY
  R169 Kirigami

BRANCH
  actiontextfield-make-qml-tooltip-consistent (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21435

AFFECTED FILES
  src/controls/ActionTextField.qml

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, domson, dkardarakos, apol, davidedmundson, 
mart, hein