D21510: Filter KNewStuff Plasma Themes by Download Tag

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:e93b567ecb7f: Filter KNewStuff Plasma Themes by Download 
Tag (authored by leinir).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21510?vs=61120=61196#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21510?vs=61120=61196

REVISION DETAIL
  https://phabricator.kde.org/D21510

AFFECTED FILES
  kcms/desktoptheme/plasma-themes.knsrc

To: leinir, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D21510#490851 , @ngraham wrote:
  
  > In D21510#488800 , @leinir wrote:
  >
  > > In D21510#488646 , @ngraham 
wrote:
  > >
  > > > Yep, seems to work and makes sense. Let's get this in so we can start 
tagging things.
  > >
  > >
  > > Aaaawesomesauce :) Land on master, or 5.16, or?
  >
  >
  > If the requisite support is entirely server-side, I'd even say the 
`Plasma/5.12` branch and merge forward. Otherwise `Plasma/5.16` and merge 
forward.
  
  
  Right, Plasma/5.16 it is :) Technically it /could/ go into 5.12... It has no 
effect unless someone runs it against Attica/KNewStuff 5.51, but i don't expect 
there'll be many using that particular combination ;)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  filter-themes-by-download-tags (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21510

To: leinir, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D21510#490850 , @ngraham wrote:
  
  > In D21510#490635 , @leinir wrote:
  >
  > > - Also filter on the ghns_excluded tag, otherwise they'll be shown...
  >
  >
  > I thought that was taken care of on the server side?
  
  
  No, all filtering happens client-side

REPOSITORY
  R119 Plasma Desktop

BRANCH
  filter-themes-by-download-tags (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21510

To: leinir, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Nathaniel Graham]

ngraham added a comment.


  In D21510#488800 , @leinir wrote:
  
  > In D21510#488646 , @ngraham 
wrote:
  >
  > > Yep, seems to work and makes sense. Let's get this in so we can start 
tagging things.
  >
  >
  > Aaaawesomesauce :) Land on master, or 5.16, or?
  
  
  If the requisite support is entirely server-side, I'd even say the 
`Plasma/5.12` branch and merge forward. Otherwise `Plasma/5.16` and merge 
forward.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  filter-themes-by-download-tags (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21510

To: leinir, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Nathaniel Graham]

ngraham added a comment.


  In D21510#490635 , @leinir wrote:
  
  > - Also filter on the ghns_excluded tag, otherwise they'll be shown...
  
  
  I thought that was taken care of on the server side?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  filter-themes-by-download-tags (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21510

To: leinir, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 61120.
leinir added a comment.


  - Also filter on the ghns_excluded tag, otherwise they'll be shown...

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21510?vs=58937=61120

BRANCH
  filter-themes-by-download-tags (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21510

AFFECTED FILES
  kcms/desktoptheme/plasma-themes.knsrc

To: leinir, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D21510#488646 , @ngraham wrote:
  
  > Yep, seems to work and makes sense. Let's get this in so we can start 
tagging things.
  
  
  Aaaawesomesauce :) Land on master, or 5.16, or?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  filter-themes-by-download-tags (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21510

To: leinir, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Yep, seems to work and makes sense. Let's get this in so we can start tagging 
things.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  filter-themes-by-download-tags (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21510

To: leinir, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D21510#472572 , @ngraham wrote:
  
  > Can you update the test plan to provide examples of themes that are 
correctly tagged so we can test this?
  >
  > - Plasma 5 only theme
  > - Plasma 4 only theme
  > - Theme that works on both Plasma 4 and 5
  
  
  When i first looked, for some reason i couldn't find any that matched the 
last option (i feel fairly certain that it was there when i originally 
checked), and then got sidetracked. Here is a list of three themes which match 
the three conditions:
  
  Plasma 5 only theme: "OxyLight 5 Plasma theme" (id: 998609)
  Plasma 4 only theme: "A Pimp Named Slickback (for the contest)" (id: 998596)
  Theme which says it works on both: "OxygenDymAero7" (id: 1305103)
  
  (and, of course, any theme which has no version set will be accepted, or we'd 
be filtering out the vast majority of themes on there...)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21510

To: leinir, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Nathaniel Graham]

ngraham added a comment.


  Can you update the test plan to provide examples of themes that are correctly 
tagged so we can test this?
  
  - Plasma 5 only theme
  - Plasma 4 only theme
  - Theme that works on both Plasma 4 and 5

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21510

To: leinir, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D21510#472514 , @ngraham wrote:
  
  > Is the content actually tagged appropriately yet? When I test this out I 
see no effect, i.e. old Plasma 4 themes like OLED Orange 
(https://store.kde.org/p/998790/) are still visible.
  
  
  Not all of it, no - we do have a bit of a chicken/egg situation going on 
here, but at least the one you linked to isn't tagged with appropriate 
versioning information (https://api.kde-look.org/ocs/v1/content/data/998790 is 
the full xml data for that item). Fair bunch of them are, though.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21510

To: leinir, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Nathaniel Graham]

ngraham added a comment.


  Is the content actually tagged appropriately yet? When I test this out I see 
no effect, i.e. old Plasma 4 themes like OLED Orange 
(https://store.kde.org/p/998790/) are still visible.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21510

To: leinir, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 58937.
leinir added a comment.


  - Add TagFilter (for top level tags), and don't explicitly reject 4

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21510?vs=58935=58937

BRANCH
  filter-themes-by-download-tags (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21510

AFFECTED FILES
  kcms/desktoptheme/plasma-themes.knsrc

To: leinir, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  Following a lengthy discussion on the topic[1], the first step
  towards getting themes cleaned up and hidden when they don't
  work is to get the ones hidden which are only for Plasma 4.
  We do this by filtering out any theme which is tagged as
  being for the major version 4 of plasma. We also allow themes
  through which have been tested to work on both, by accepting
  themes which are tagged as both 4 and 5.
  
  [1] https://phabricator.kde.org/T8126#184198 and down a few pages

TEST PLAN
  See themes tagged as plasma##majorversion=4 being hidden, except when they
  are also tagged as plasma##majorversion=5. This can most easily be done
  by launching the plasma theme dialog and opening Get New Themes from there
  and turning on debugging for KNewStuff(Core) like so:
  
  `QT_LOGGING_RULES="org.kde.knewstuff*=true" kcmshell5 kcm_desktoptheme`
  
  and then watching the output, and seeing that content is being rejected
  by the InequalityFilter for plasma##majorversion when appropriate.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  filter-themes-by-download-tags (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21510

AFFECTED FILES
  kcms/desktoptheme/plasma-themes.knsrc

To: leinir
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart