D21803: PanelView: align setting of masks with how it's done for dialogs/tooltips
This revision was automatically updated to reflect the committed changes. Closed by commit R120:f65a0eee09da: PanelView: align setting of masks with how it's done for dialogs/tooltips (authored by kossebau). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21803?vs=59800&id=59882 REVISION DETAIL https://phabricator.kde.org/D21803 AFFECTED FILES shell/panelview.cpp shell/panelview.h To: kossebau, #plasma, hein Cc: hein, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D21803: PanelView: align setting of masks with how it's done for dialogs/tooltips
hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Thanks for restoring my sanity & faith in panels, this annoyed me for weeks :) REPOSITORY R120 Plasma Workspace BRANCH alignpanelmaskhandlingtodialog REVISION DETAIL https://phabricator.kde.org/D21803 To: kossebau, #plasma, hein Cc: hein, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D21803: PanelView: align setting of masks with how it's done for dialogs/tooltips
kossebau updated this revision to Diff 59800. kossebau added a comment. for completeness also remove mask for m_backgroundHints == Plasma::Types::NoBackground REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21803?vs=59798&id=59800 BRANCH alignpanelmaskhandlingtodialog REVISION DETAIL https://phabricator.kde.org/D21803 AFFECTED FILES shell/panelview.cpp shell/panelview.h To: kossebau, #plasma Cc: plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D21803: PanelView: align setting of masks with how it's done for dialogs/tooltips
kossebau added a comment. Compare with DialogPrivate::updateTheme(): https://phabricator.kde.org/source/plasma-framework/browse/master/src/plasmaquick/dialog.cpp$229 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21803 To: kossebau, #plasma Cc: plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D21803: PanelView: align setting of masks with how it's done for dialogs/tooltips
kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY With Plasma dialogs & tooltips the mask is only set on the widget itself if compositing is off. Instead is the mask explicitly passed for the KWindowEffects. The recent changes to fix the blurbehind & contrast mask with panels instead turned to always set the mask on the widget. For some reason yet to be understood this can sometimes result in an offset by a pixel between the mask used for painting and the mask used for the window effects. Aligning the mask setting code with the one for dialogs & tooltips makes the symptom go away for now, and also delivers consistency. CCBBUG: 406380 TEST PLAN Using different themes, including Adapta & Arc Dark, a gap can no longer been seen. Only with compositing turned off, which is old behaviour due to the real bug yet to understand completly. Resizing panels or changing screen resolution also works without breaking rendering or panel contents interaction. REPOSITORY R120 Plasma Workspace BRANCH alignpanelmaskhandlingtodialog REVISION DETAIL https://phabricator.kde.org/D21803 AFFECTED FILES shell/panelview.cpp shell/panelview.h To: kossebau, #plasma Cc: plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
