This revision was automatically updated to reflect the committed changes.
Closed by commit R128:2d1514b4de0e: Have more contrast in circle-style user
avatars (authored by filipf).
REPOSITORY
R128 User Manager
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21926?vs=60225=60252
filipf updated this revision to Diff 60225.
filipf added a comment.
This revision is now accepted and ready to land.
also edit the svg
change the style a bit
REPOSITORY
R128 User Manager
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21926?vs=60122=60225
BRANCH
master
filipf planned changes to this revision.
filipf added a comment.
Good catch. I'll need a bit of help with that but should be doable.
REPOSITORY
R128 User Manager
REVISION DETAIL
https://phabricator.kde.org/D21926
To: filipf, #vdg, ngraham, ndavis
Cc: ngraham, plasma-devel, LeGast00n,
ndavis added a comment.
Unless you want to get rid of the SVG these avatars were created from, you
should also update `pics_sources/avatar.svg`.
REPOSITORY
R128 User Manager
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D21926
To: filipf, #vdg, ngraham, ndavis
Cc:
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
There we go, much better. Thanks!
REPOSITORY
R128 User Manager
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D21926
To: filipf, #vdg, ngraham, ndavis
Cc: ngraham,
filipf updated this revision to Diff 60122.
filipf added a comment.
fix permissions, take 2
REPOSITORY
R128 User Manager
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21926?vs=60120=60122
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D21926
AFFECTED FILES
filipf updated this revision to Diff 60120.
filipf edited the test plan for this revision.
filipf added a comment.
fix permissions
REPOSITORY
R128 User Manager
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21926?vs=60118=60120
BRANCH
circle-avatars-better-contrast (branched
ngraham added a comment.
Looks like the permissions have changed too?
REPOSITORY
R128 User Manager
REVISION DETAIL
https://phabricator.kde.org/D21926
To: filipf
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen,
Pitel, ZrenBot, himcesjf, lesliezhai,
filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.
REVISION SUMMARY
Our circular avatar currently don't have the best contrast between their
background and main element, which is especially evident
