D21981: Set SwipeListItem implicitHeight to be the maximum of content and actions

2019-06-22 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R169:43eb5fae5784: Set SwipeListItem implicitHeight to be the maximum of content and actions (authored by davidre). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D21981: Set SwipeListItem implicitHeight to be the maximum of content and actions

2019-06-22 Thread Nathaniel Graham
ngraham added a comment. Now that I look at it, the right-most button's right padding is also too high; it should be much closer to the right edge of the list item. Maybe good material for another patch. REPOSITORY R169 Kirigami BRANCH height (branched from master) REVISION DETAIL

D21981: Set SwipeListItem implicitHeight to be the maximum of content and actions

2019-06-22 Thread Nathaniel Graham
ngraham added subscribers: mart, ngraham. ngraham added reviewers: Kirigami, mart. ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM. @mart? REPOSITORY R169 Kirigami BRANCH height (branched from master) REVISION DETAIL

D21981: Set SwipeListItem implicitHeight to be the maximum of content and actions

2019-06-22 Thread David Redondo
davidre created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Otherwise if the content is smaller than the actions they will be partially outside out of the item REPOSITORY R169 Kirigami