This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c0acd1434147: [libtaskmanager] Track stacking order and
window activation (on X11) (authored by hein).
REPOSITORY
davidedmundson added a comment.
One minor comment, and anthonyfieroni's comment, and this is good to go.
INLINE COMMENTS
> xwindowtasksmodel.cpp:203
> +cachedStackingOrder = KWindowSystem::stackingOrder();
> +q->dataChanged(q->index(0, 0), q->index(q->rowCount() - 1,
pino added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in xwindowtasksmodel.cpp:673-675
> That's double lookup in intensive called function, what about
>
> int idx = d->lastActivated.indexOf(window);
> if (idx >= 0)
>return d->lastActivated.at(idx);
@anthonyfieroni
anthonyfieroni added inline comments.
INLINE COMMENTS
> xwindowtasksmodel.cpp:673-675
> +if (d->lastActivated.contains(window)) {
> +return d->lastActivated.value(window);
> +}
That's double lookup in intensive called function, what about
int idx =
hein created this revision.
hein added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
hein requested review of this revision.
REVISION SUMMARY
`TaskGroupingProxyModel::requestToggleMaximized` now uses this to
minimize and restore groups of windows
