D22128: [Kickoff] Redo tab bar separator's geometry

2019-07-04 Thread Filip Fila 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:76045bf20e07: [Kickoff] Redo tab bar separators 
geometry (authored by filipf).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22128?vs=60750=61179

REVISION DETAIL
  https://phabricator.kde.org/D22128

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: filipf, #plasma, #vdg, ndavis, ngraham
Cc: ngraham, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22128: [Kickoff] Redo tab bar separator's geometry

2019-07-01 Thread Filip Fila 
filipf added a comment.


  Can anyone from #plasma  have a 
quick look if this is okay?
  
  I went with the approach of not initially defining geometry, and define it 
only as a part of the anchor changes?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-tabbarseparator-geometr (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22128

To: filipf, #plasma, #vdg, ndavis, ngraham
Cc: ngraham, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22128: [Kickoff] Redo tab bar separator's geometry

2019-06-30 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.


  In D22128#487965 , @ndavis wrote:
  
  > Sorry, my bad once again. I hadn't actually applied D22108 
. It works for me now. The tab highlight 
width problem must be somewhere else since this patch didn't introduce that bug.
  
  
  Oh, I must have made the same mistake, because upon trying again it now works.
  
  We should also make the tab highlight look like the new style in T11124 
. :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-tabbarseparator-geometr (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22128

To: filipf, #plasma, #vdg, ndavis, ngraham
Cc: ngraham, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22128: [Kickoff] Redo tab bar separator's geometry

2019-06-28 Thread Noah Davis 
ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  Sorry, my bad once again. I hadn't actually applied D22108 
. It works for me now. The tab highlight 
width problem must be somewhere else since this patch didn't introduce that 
regression.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-tabbarseparator-geometr (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22128

To: filipf, #plasma, #vdg, ndavis
Cc: ngraham, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22128: [Kickoff] Redo tab bar separator's geometry

2019-06-28 Thread Noah Davis 
ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  whoops, didn't mean to accept

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22128

To: filipf, #plasma, #vdg, ndavis
Cc: ngraham, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22128: [Kickoff] Redo tab bar separator's geometry

2019-06-28 Thread Noah Davis 
ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  In D22128#487943 , @ngraham wrote:
  
  > Even after also applying D22108  it's 
better but still not quite touching the line for me (1x scale, 1080p screen): 
F6941090: Screenshot_20190628_145136.png 
  
  
  Same here.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-tabbarseparator-geometr (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22128

To: filipf, #plasma, #vdg, ndavis
Cc: ngraham, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22128: [Kickoff] Redo tab bar separator's geometry

2019-06-28 Thread Filip Fila 
filipf added a comment.


  In D22128#487943 , @ngraham wrote:
  
  > Even after also applying D22108  it's 
better but still not quite touching the line for me (1x scale, 1080p screen): 
F6941090: Screenshot_20190628_145136.png 
  
  
  Hmm, am I patching the wrong thing in D22108 
? I wanted to be editing this file:
  
/usr/lib/qt/qml/org/kde/plasma/components/TabBar.qml

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22128

To: filipf, #plasma, #vdg
Cc: ngraham, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22128: [Kickoff] Redo tab bar separator's geometry

2019-06-28 Thread Nathaniel Graham 
ngraham added a comment.


  Even after also applying D22108  it's 
better but still not quite touching the line for me (1x scale, 1080p screen): 
F6941090: Screenshot_20190628_145136.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22128

To: filipf, #plasma, #vdg
Cc: ngraham, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22128: [Kickoff] Redo tab bar separator's geometry

2019-06-28 Thread Filip Fila 
filipf added a comment.


  Don't know, I removed both of the patches and the issue's still there. Yeah 
this was 2x scaling and the indicator should be 6px.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22128

To: filipf, #plasma, #vdg
Cc: ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22128: [Kickoff] Redo tab bar separator's geometry

2019-06-27 Thread Noah Davis 
ndavis added a comment.


  Since these seem to be scaled 2x, the thicker (6px@2x) highlight is more 
desirable.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22128

To: filipf, #plasma, #vdg
Cc: ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22128: [Kickoff] Redo tab bar separator's geometry

2019-06-27 Thread Noah Davis 
ndavis added a comment.


  Why is the tab highlight thicker in these
  
  F6939066: Screenshot_20190627_234222.png 

  F6939070: Screenshot_20190628_000624.png 

  
  And thinner in these?
  
  F6939067: Screenshot_20190627_234519.png 

  F6939065: Screenshot_20190627_234358.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22128

To: filipf, #plasma, #vdg
Cc: ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22128: [Kickoff] Redo tab bar separator's geometry

2019-06-27 Thread Filip Fila 
filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  This patch makes Kickoff tab indicators glide(patch _) on the tab bar 
separator in all 4 orientations.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-tabbarseparator-geometr (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22128

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: filipf
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart