D22176: Rework system tray settings

ngraham added a comment. Oops. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22176 To: nicolasfella, #plasma, #vdg Cc: kmaterka, filipf, broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D22176: Rework system tray settings

kmaterka added a comment. @ngraham You commented in wrong revision, this was is abandoned :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22176 To: nicolasfella, #plasma, #vdg Cc: kmaterka, filipf, broulik, ngraham, plasma-devel, LeGast00n,

D22176: Rework system tray settings

ngraham added inline comments. INLINE COMMENTS > ConfigGeneral.qml:23 > +import QtQuick 2.5 > +import QtQuick.Controls 1.4 as QQC1 > +import QtQuick.Controls 2.5 as QQC2 there are no longer any QQC1 items here; you can remove this import entirely > ConfigGeneral.qml:65 > +

D22176: Rework system tray settings

nicolasfella added a comment. yes, feel free to take it over :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22176 To: nicolasfella, #plasma, #vdg Cc: kmaterka, filipf, broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D22176: Rework system tray settings

ngraham added a comment. Maybe you can commandeer it if @nicolasfella lacks the time? The two of you can share credit. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22176 To: nicolasfella, #plasma, #vdg Cc: kmaterka, filipf, broulik, ngraham,

D22176: Rework system tray settings

kmaterka added a comment. It looks abandoned, but rewrite of configuration is very needed, users are confused (and there are bug reports due to this). I have few more idea: - checkbox "Always show all entries" is misleading now. It won't enable all applets. When checked, it is no

D22176: Rework system tray settings

ngraham added inline comments. INLINE COMMENTS > ConfigGeneral.qml:101 > +enabled: !showAllCheckBox.checked > +model: isPlasmoid ? [i18n("Auto"), i18n("Shown"), > i18n("Hidden"), i18n("Disabled")] : [i18n("Auto"), i18n("Shown"), > i18n("Hidden")] > +

D22176: Rework system tray settings

kmaterka added a comment. D25580 pushed, @nicolasfella, can you rebase? In addition, as we are basically removing categories, you need to remove: - `shownCategories` from `main.qml` - `categoryShown` from `AbstractItem.qml` -

D22176: Rework system tray settings

kmaterka added a comment. As mentioned earlier: this is a great idea, but has issues with the model. Please check D25580 as a per-requirement. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22176 To: nicolasfella,

D22176: Rework system tray settings

ngraham added a comment. Ping. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22176 To: nicolasfella, #plasma, #vdg Cc: kmaterka, filipf, broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot,

D22176: Rework system tray settings

kmaterka added a comment. In D22176#519600 , @nicolasfella wrote: > I think QQC1 TableView and the new TableView are quite different things. I had some issues with the QQC1 TableView and my new Model, so I decided to use something else, but I

D22176: Rework system tray settings

nicolasfella added a comment. In D22176#519573 , @kmaterka wrote: > @nicolasfella I updated D23413 , now it can be used in configuration entries. Can you check if you can use this? That makes sense,

D22176: Rework system tray settings

kmaterka added a comment. @nicolasfella I updated D23413 , now it can be used in configuration entries. Can you check if you can use this? I like the idea of removing "Categories", these are confusing and probably no-one uses them. **Important

D22176: Rework system tray settings

kmaterka added a comment. @nicolasfella Correct me if I'm wrong. EntryModel is created on the first use and it is populated in the constructor. If user runs application that uses StatusNotifier (for example Skype, Dropbox, Electron apps, any Windows app via Wine, etc) later, it won't be

D22176: Rework system tray settings

ngraham added a comment. @nicolasfella would you be able to move forward with this? I have some additions in mind for the config UI but I don't think it makes to start work on them while this very desirable cleanup is still in flight. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D22176: Rework system tray settings

filipf added a comment. In D22176#489327 , @ngraham wrote: > Honestly I would support staying with the QQC1 TableView for now. Trying to move to QQC2 without a replacement for it just means we're rolling our own table view, which seems even

D22176: Rework system tray settings

ngraham added a comment. In D22176#489327 , @ngraham wrote: > The generally accepted way to do this is to use alternating background colors. The old table view got this automatically, however this patch ports away from it since it's QQC1 only.

D22176: Rework system tray settings

ngraham added a comment. In D22176#489325 , @filipf wrote: > Nice, looks good and is a lot cleaner. > > I'm mostly only echoing @broulik here, but I think we should still have some sort of help with figuring out which entry belongs to which

D22176: Rework system tray settings

filipf added subscribers: broulik, filipf. filipf added a comment. Nice, looks good and is a lot cleaner. I'm mostly only echoing @broulik here, but I think we should still have some sort of help with figuring out which entry belongs to which row of buttons. This (mockup) is

D22176: Rework system tray settings

ngraham added a comment. Nice!!! Let's give the scrollview that holds this list a visible frame, like we did in the Purpose job dialog. Also maybe rename the "General" tab to say "Entries" since that's all there is there. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D22176: Rework system tray settings

nicolasfella created this revision. nicolasfella added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY The current system tray settings has two pages with two slightly different