D22230: [TaskManager] Follow KDE title & subtitle style

2019-07-04 Thread Filip Fila 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:741ffda94294: [TaskManager] Follow KDE title  
subtitle style (authored by filipf).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22230?vs=61062=61180

REVISION DETAIL
  https://phabricator.kde.org/D22230

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: filipf, #plasma, #vdg, ngraham, hein
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22230: [TaskManager] Follow KDE title & subtitle style

2019-07-03 Thread Filip Fila 
filipf updated this revision to Diff 61062.
filipf added a comment.


  use DescriptiveLabel for subtitle/artist info

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22230?vs=61051=61062

BRANCH
  tooltip-media-titlesubtitle-style (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22230

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: filipf, #plasma, #vdg, ngraham, hein
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22230: [TaskManager] Follow KDE title & subtitle style

2019-07-03 Thread Eike Hein 
hein added a comment.


  @filipf: Yep, sounds sensible :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  tooltip-media-titlesubtitle-style (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22230

To: filipf, #plasma, #vdg, ngraham, hein
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22230: [TaskManager] Follow KDE title & subtitle style

2019-07-03 Thread Filip Fila 
filipf added a comment.


  @hein would you want me to use PlasmaExtras.DescriptiveLabel for the 
subtitle, same as in D22231 ? Makes us not 
have to specify opacity.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  tooltip-media-titlesubtitle-style (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22230

To: filipf, #plasma, #vdg, ngraham, hein
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22230: [TaskManager] Follow KDE title & subtitle style

2019-07-03 Thread Filip Fila 
filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  We're currently using a custom style for song titles and artist info in 
tooltips.
  
  This patch applies the common KDE title & subtitle style as seen in e.g. 
Kickoff or plasma-nm applet.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  tooltip-media-titlesubtitle-style (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22230

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: filipf
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart