D22231: [Lock screen] Follow KDE title & subtitle style

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b414ac1c7a09: [Lock screen] Follow KDE title  
subtitle style (authored by filipf).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22231?vs=61060=61245

REVISION DETAIL
  https://phabricator.kde.org/D22231

AFFECTED FILES
  lookandfeel/contents/lockscreen/MediaControls.qml

To: filipf, #plasma, #vdg, ngraham
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22231: [Lock screen] Follow KDE title & subtitle style

[Filip Fila]

filipf added a comment.


  Ping, with D22230  landed this should 
also follow quite soon.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22231

To: filipf, #plasma, #vdg, ngraham
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22231: [Lock screen] Follow KDE title & subtitle style

[Filip Fila]

filipf updated this revision to Diff 61060.
filipf added a comment.


  use DescriptiveLabel for subtitle

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22231?vs=61052=61060

BRANCH
  lockscreen-titlesubtitle-style (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22231

AFFECTED FILES
  lookandfeel/contents/lockscreen/MediaControls.qml

To: filipf, #plasma, #vdg, ngraham
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22231: [Lock screen] Follow KDE title & subtitle style

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> MediaControls.qml:132
> +font.pointSize: theme.smallestFont.pointSize + 1
> +opacity: 0.6
>  }

Use `PlasmaExtras.DescriptiveLabel` instead

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22231

To: filipf, #plasma, #vdg, ngraham
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22231: [Lock screen] Follow KDE title & subtitle style

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  We're currently using a custom tyle for song titles and artist info in the 
lock screen's media controls.
  
  This patch applies common KDE title & subtitle style as seen in e.g. Kickoff 
or plasma-nm applet-
  
  Becuase the lock screen has increased font sizes, corrections for the title 
and subtitle have also been made.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  lockscreen-titlesubtitle-style (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22231

AFFECTED FILES
  lookandfeel/contents/lockscreen/MediaControls.qml

To: filipf
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart