D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC

2019-07-08 Thread Mihai Sorin Dobrescu
msdobrescu added a comment. In D22256#492127 , @davidre wrote: > I guess one drawback is that you have to reindex all the files when the sort mode is changed. I expect to simply reload the list, from the filesystem. That should be done

D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC

2019-07-08 Thread David Redondo
davidre added a comment. I guess one drawback is that you have to reindex all the files when the sort mode is changed. REVISION DETAIL https://phabricator.kde.org/D22256 To: msdobrescu, ngraham, davidre, #plasma Cc: davidedmundson, davidre, ngraham, plasma-devel, LeGast00n, jraleigh,

D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC

2019-07-07 Thread Mihai Sorin Dobrescu
msdobrescu added a comment. In D22256#491942 , @davidedmundson wrote: > The fundamental problem with this approach is you only sort through the dirs correctly, but not the total across multiple paths. > > i.e > If I have two paths dirA

D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC

2019-07-07 Thread David Edmundson
davidedmundson added a comment. The fundamental problem with this approach is you only sort through the dirs correctly, but not the total across multiple paths. i.e If I have two paths dirA and dirB and want things sorted by date this patch will have all the images in dirA sorted by

D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC

2019-07-05 Thread Mihai Sorin Dobrescu
msdobrescu updated this revision to Diff 61201. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22256?vs=61191=61201 REVISION DETAIL https://phabricator.kde.org/D22256 AFFECTED FILES wallpapers/image/backgroundlistmodel.cpp wallpapers/image/backgroundlistmodel.h

D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC

2019-07-05 Thread Mihai Sorin Dobrescu
msdobrescu updated this revision to Diff 61191. msdobrescu edited the summary of this revision. msdobrescu added a comment. Added Reversed, DirsFirst/DirsLast, IgnoreCase, LocaleAware options. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22256?vs=6=61191 REVISION DETAIL

D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC

2019-07-04 Thread Mihai Sorin Dobrescu
msdobrescu added a comment. In D22256#490558 , @davidedmundson wrote: > This is awkward timing. > > See D22121 : [Image Wallpaper Slideshow] Allow setting of different sorting orders > > Sorry

D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC

2019-07-04 Thread David Edmundson
davidedmundson added a comment. This is awkward timing. See D22121 : [Image Wallpaper Slideshow] Allow setting of different sorting orders Sorry REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22256 To:

D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC

2019-07-03 Thread Mihai Sorin Dobrescu
msdobrescu created this revision. msdobrescu added reviewers: ngraham, davidre. msdobrescu added a project: Plasma. Herald added a subscriber: plasma-devel. msdobrescu requested review of this revision. REVISION SUMMARY Another take of bug 186181, as POC. The idea is to use filesystem sorting