D22503: kcms: translations: use availableDomainTranslations from plasmashell instead of systemsettings

2019-07-17 Thread Eike Hein 
hein added a comment.


  Sorry, the cryptic comment can be safely ignored. I had a concern at first, 
then looked into it, decided I'm OK with the patch and forgot the started 
sentence. :-)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22503

To: jbbgameich, hein
Cc: bshah, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22503: kcms: translations: use availableDomainTranslations from plasmashell instead of systemsettings

2019-07-17 Thread Jonah Brüchert 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:08a802656df5: kcms: translations: use 
availableDomainTranslations from plasmashell instead of… (authored by 
jbbgameich).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22503?vs=61894=61931

REVISION DETAIL
  https://phabricator.kde.org/D22503

AFFECTED FILES
  kcms/translations/translations.cpp
  kcms/translations/translationsmodel.cpp

To: jbbgameich, hein
Cc: bshah, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22503: kcms: translations: use availableDomainTranslations from plasmashell instead of systemsettings

2019-07-17 Thread Bhushan Shah 
bshah added a comment.


  (me confused by cryptic comment) :P

REPOSITORY
  R120 Plasma Workspace

BRANCH
  translations-no-systemsettings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22503

To: jbbgameich, hein
Cc: bshah, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22503: kcms: translations: use availableDomainTranslations from plasmashell instead of systemsettings

2019-07-17 Thread Eike Hein 
hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  This creayes

REPOSITORY
  R120 Plasma Workspace

BRANCH
  translations-no-systemsettings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22503

To: jbbgameich, hein
Cc: bshah, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22503: kcms: translations: use availableDomainTranslations from plasmashell instead of systemsettings

2019-07-17 Thread Bhushan Shah 
bshah added subscribers: hein, bshah.
bshah added a comment.


  Personally speaking, +1, would love opinion of @hein

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22503

To: jbbgameich
Cc: bshah, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22503: kcms: translations: use availableDomainTranslations from plasmashell instead of systemsettings

2019-07-17 Thread Jonah Brüchert 
jbbgameich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  The kcm might be used with different settings apps like plasma-settings, in 
that case systemsettings is not installed.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  translations-no-systemsettings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22503

AFFECTED FILES
  kcms/translations/translations.cpp
  kcms/translations/translationsmodel.cpp

To: jbbgameich
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart