This revision was automatically updated to reflect the committed changes.
Closed by commit R120:989a7759a969: Calculate first clickable point, from the
top-left (authored by kmaterka, committed by davidedmundson).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator
kmaterka removed a reviewer: Plasma: Workspaces.
kmaterka added inline comments.
INLINE COMMENTS
> davidedmundson wrote in sniproxy.cpp:576
> This point was marked as closed, but not changed. Probably my fault for not
> expanding.
>
> We move the window so that it's at x-clickPoint
> The relat
davidedmundson added inline comments.
INLINE COMMENTS
> sniproxy.cpp:576
> event->root = QX11Info::appRootWindow();
> event->root_x = x;
> event->root_y = y;
This point was marked as closed, but not changed. Probably my fault for not
expanding.
We move the window so
kmaterka updated this revision to Diff 62723.
kmaterka marked 3 inline comments as done.
kmaterka added a comment.
Review changes. Call to the calculateClickPoint is local and on only on mouse
click, not on every icon update.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22767?vs=6
davidedmundson added a comment.
Thanks for doing some work on xembedsniproxy!
INLINE COMMENTS
> sniproxy.cpp:239
>
> +calculateClickPoint(image);
> +
This is quite expensive to do every frame (some animate), I think we can do
something else, see below.
> sniproxy.cpp:530
> else
kmaterka created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kmaterka requested review of this revision.
REVISION SUMMARY
Wine is using XWindow Shape Extension for transparent tray icons.
We need to find first clickable point starting from top-left.
