D22885: Add global animation speed slider to workspace options KCM

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d2f545bfdc5d: Add global animation speed slider to 
workspace options KCM (authored by davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22885?vs=65886=66825

REVISION DETAIL
  https://phabricator.kde.org/D22885

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions.cpp
  kcms/workspaceoptions/workspaceoptions.h

To: davidedmundson, #plasma, broulik
Cc: ngraham, GB_2, broulik, anthonyfieroni, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22885: Add global animation speed slider to workspace options KCM

[David Edmundson]

davidedmundson updated this revision to Diff 65886.
davidedmundson added a comment.


  update names as per discussion

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22885?vs=63844=65886

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22885

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions.cpp
  kcms/workspaceoptions/workspaceoptions.h

To: davidedmundson, #plasma, broulik
Cc: ngraham, GB_2, broulik, anthonyfieroni, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22885: Add global animation speed slider to workspace options KCM

[Nathaniel Graham]

ngraham added a comment.


  Is this going to be able to land before Plasma 5.17 branches in 8 days?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22885

To: davidedmundson, #plasma, broulik
Cc: ngraham, GB_2, broulik, anthonyfieroni, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22885: Add global animation speed slider to workspace options KCM

[David Edmundson]

davidedmundson updated this revision to Diff 63844.
davidedmundson added a comment.


  rename config option and variable and property names

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22885?vs=62956=63844

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22885

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions.cpp
  kcms/workspaceoptions/workspaceoptions.h

To: davidedmundson, #plasma
Cc: GB_2, broulik, anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22885: Add global animation speed slider to workspace options KCM

[Kai Uwe Broulik]

broulik added a comment.


  We agreed that code-wise a multiplier is easier but then the name of the 
group should be adjusted to reflect that.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22885

To: davidedmundson, #plasma
Cc: GB_2, broulik, anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22885: Add global animation speed slider to workspace options KCM

[Björn Feber]

GB_2 added a comment.


  In D22885#505635 , @broulik wrote:
  
  > Why is it confusing? I find it more confusing if `AnimationSpeed=0.5` means 
*faster* instead of "half the speed" as reading that line would suggest.
  >  However, KWin seems to do it the same way round...
  
  
  I agree.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22885

To: davidedmundson, #plasma
Cc: GB_2, broulik, anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22885: Add global animation speed slider to workspace options KCM

[Kai Uwe Broulik]

broulik added a comment.


  Why is it confusing? I find it more confusing if `AnimationSpeed=0.5` means 
*faster* instead of "half the speed" as reading that line would suggest

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22885

To: davidedmundson, #plasma
Cc: broulik, anthonyfieroni, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart