D23125: fix bridge master:slave mapping by-name
fusitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D23125 To: sitter, jgrulich Cc: fusitter, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D23125: fix bridge master:slave mapping by-name
fusitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D23125 To: sitter, jgrulich Cc: fusitter, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D23125: fix bridge master:slave mapping by-name
This revision was automatically updated to reflect the committed changes. Closed by commit R116:9fccc9a8d599: fix bridge master:slave mapping by-name (authored by sitter). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23125?vs=64036=64320 REVISION DETAIL https://phabricator.kde.org/D23125 AFFECTED FILES libs/editor/connectioneditorbase.cpp libs/editor/settings/bondwidget.cpp libs/editor/settings/bondwidget.h libs/editor/settings/bridgewidget.cpp libs/editor/settings/bridgewidget.h libs/editor/settings/teamwidget.cpp libs/editor/settings/teamwidget.h To: sitter, jgrulich Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D23125: fix bridge master:slave mapping by-name
sitter updated this revision to Diff 64036. sitter added a comment. drop more extra spaces -.- REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23125?vs=64035=64036 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23125 AFFECTED FILES libs/editor/connectioneditorbase.cpp libs/editor/settings/bondwidget.cpp libs/editor/settings/bondwidget.h libs/editor/settings/bridgewidget.cpp libs/editor/settings/bridgewidget.h libs/editor/settings/teamwidget.cpp libs/editor/settings/teamwidget.h To: sitter, jgrulich Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D23125: fix bridge master:slave mapping by-name
sitter updated this revision to Diff 64035. sitter added a comment. drop excess spaces REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23125?vs=64034=64035 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23125 AFFECTED FILES libs/editor/connectioneditorbase.cpp libs/editor/settings/bondwidget.cpp libs/editor/settings/bondwidget.h libs/editor/settings/bridgewidget.cpp libs/editor/settings/bridgewidget.h libs/editor/settings/teamwidget.cpp libs/editor/settings/teamwidget.h To: sitter, jgrulich Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D23125: fix bridge master:slave mapping by-name
sitter updated this revision to Diff 64034. sitter retitled this revision from "fix bridge/team/bond master:slave mapping by-name" to "fix bridge master:slave mapping by-name". sitter edited the summary of this revision. sitter added a comment. apply change to bond and team set id at construction time instead of looking it up at popluation time REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23125?vs=63656=64034 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23125 AFFECTED FILES libs/editor/connectioneditorbase.cpp libs/editor/settings/bondwidget.cpp libs/editor/settings/bondwidget.h libs/editor/settings/bridgewidget.cpp libs/editor/settings/bridgewidget.h libs/editor/settings/teamwidget.cpp libs/editor/settings/teamwidget.h To: sitter, jgrulich Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D23125: fix bridge master:slave mapping by-name
jgrulich added a comment. The parent knows the connection id, if you look into ConnectionEditorBase::initialize(), then you can get the id using "m_connection->id()" You can add additional **masterId** parameter so you don't need to go through the whole connection list to get the id. Also, this same improvement can be done in BondWidget and TeamWidget, where very same code is used (if would be so kind to do so :) ) REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D23125 To: sitter, jgrulich Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D23125: fix bridge master:slave mapping by-name
sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. sitter requested review of this revision. REVISION SUMMARY a slave may be mapped to a master by either the uuid of the master OR the connection name of the master. determine our current connection name and if it is the one referenced by the slave we consider ourselves master of that slave. since we do not have access to the connection name inside the bridgewidget I'm opting to pop it out of connection list on-demand. it may be more efficient to get it passed in by the parent widget (which I think knows the name). I am not sure if there may be pitfalls with considering the name static though. also partially unpack the if condition so it's a bit easier on the eyes with the newly added complexity TEST PLAN nmcli c add type bridge ifname br0 autoconnect yes con-name br0 stp off nmcli c add type bridge-slave autoconnect yes con-name enp4s0 ifname enp4s0 master br0 kcm correctly shows enp4s0 as slave of br0 REPOSITORY R116 Plasma Network Management Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D23125 AFFECTED FILES libs/editor/settings/bridgewidget.cpp To: sitter, jgrulich Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
