meven created this revision.
meven added reviewers: broulik, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  The code is not great, I would be open to have a suggestion to improve it.
  I tried to pass Solid::Device directly to the qml side and using QHash to 
store vendor and product but they are not QObject so it can't work.

TEST PLAN
  After:

REPOSITORY
  R102 KInfoCenter

BRANCH
  dev2

REVISION DETAIL
  https://phabricator.kde.org/D23152

AFFECTED FILES
  Modules/energy/batterymodel.cpp
  Modules/energy/batterymodel.h
  Modules/energy/package/contents/ui/main.qml

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Reply via email to