D23198: Skip mime type check only for files on network mounts

ngraham added a comment. What's the current status of this patch? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23198 To: meven, #plasma, dfaure Cc: davidedmundson, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D23198: Skip mime type check only for files on network mounts

dfaure added a comment. My suggestion is (still) "improve KFileItem to enable SkipMimeTypeFromContent automatically if isSlow is true" [possibly with another flag if you think there are actually use cases for mime-magic over network mounts] Then all this code isn't needed. REPOSITORY

D23198: Skip mime type check only for files on network mounts

meven added a comment. In D23198#523708 , @broulik wrote: > So I guess we can use the `KFileItem::isSlow()` here now, too? No because isSlow is a member function but the purpose here is to choose a constructor for KFileItem in the first

D23198: Skip mime type check only for files on network mounts

broulik added a comment. So I guess we can use the `KFileItem::isSlow()` here now, too? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23198 To: meven, #plasma, dfaure Cc: davidedmundson, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D23198: Skip mime type check only for files on network mounts

meven added a comment. In D23198#518001 , @dfaure wrote: > What I mean is: > > 1. improve KFileItem::isSlow to use this Solid code diff at D23420 REPOSITORY R119 Plasma Desktop REVISION DETAIL

D23198: Skip mime type check only for files on network mounts

meven added a comment. In D23198#518001 , @dfaure wrote: > What I mean is: > > 1. improve KFileItem::isSlow to use this Solid code > 2. improve KFileItem to enable SkipMimeTypeFromContent automatically if isSlow is true Sorry I

D23198: Skip mime type check only for files on network mounts

meven added a comment. In D23198#518001 , @dfaure wrote: > What I mean is: > > 1. improve KFileItem::isSlow to use this Solid code > 2. improve KFileItem to enable SkipMimeTypeFromContent automatically if isSlow is true Sorry I

D23198: Skip mime type check only for files on network mounts

dfaure added a comment. What I mean is: 1. improve KFileItem::isSlow to use this Solid code 2. improve KFileItem to enable SkipMimeTypeFromContent automatically if isSlow is true However maybe we don't want that in dolphin? Not sure. (In that case a new enum value can be added,

D23198: Skip mime type check only for files on network mounts

meven added a comment. In D23198#517980 , @dfaure wrote: > Why not do this in KFileItem::isSlow() itself? > (and enable SkipMimeTypeFromContent when isSlow is true) First because KFileItem::isSlow is a member function of KFileItem and

D23198: Skip mime type check only for files on network mounts

dfaure added a comment. Why not do this in KFileItem::isSlow() itself? (and enable SkipMimeTypeFromContent when isSlow is true) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23198 To: meven, #plasma, dfaure Cc: davidedmundson, ngraham, broulik,

D23198: Skip mime type check only for files on network mounts

meven added a comment. My last change is more a Proof of Concept : using Solid to avoid mime check. I would be in favor of adding a static function to Solid encompassing this use case. For instance : bool Solid::isMountedOnNetworkShare(const QString ) static; But the good part is

D23198: Skip mime type check only for files on network mounts

meven updated this revision to Diff 64283. meven added a comment. Use solid to find network shares REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23198?vs=63859=64283 BRANCH arcpatch-D23198 REVISION DETAIL https://phabricator.kde.org/D23198

D23198: Skip mime type check only for files on network mounts

meven added a comment. In D23198#514335 , @davidedmundson wrote: > > True, but then that implies that KFileItem::isSlow() which has the same code is flawed in the same way. > > It is. We have ironic lockups there. Indeed after

D23198: Skip mime type check only for files on network mounts

davidedmundson added a comment. > True, but then that implies that KFileItem::isSlow() which has the same code is flawed in the same way. It is. We have ironic lockups there. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23198 To: meven, #plasma,

D23198: Skip mime type check only for files on network mounts

meven added a comment. For reference in GNOME, the equivalent feature looks like : https://i.stack.imgur.com/V7Fpk.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23198 To: meven, #plasma, dfaure Cc: ngraham, broulik, plasma-devel, LeGast00n,

D23198: Skip mime type check only for files on network mounts

meven added a comment. In D23198#512999 , @ngraham wrote: > In D23198#512942 , @broulik wrote: > > > `fileSystemType` calls `statvfs` which might also block, so I don't think this helps. > >

D23198: Skip mime type check only for files on network mounts

ngraham added a comment. In D23198#512942 , @broulik wrote: > `fileSystemType` calls `statvfs` which might also block, so I don't think this helps. True, but then that implies that `KFileItem::isSlow()` which has the same code is flawed

D23198: Skip mime type check only for files on network mounts

meven updated this revision to Diff 63859. meven added a comment. Use toLocalFile() instead of path() REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23198?vs=63855=63859 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23198

D23198: Skip mime type check only for files on network mounts

broulik added a comment. `fileSystemType` calls `statvfs` which might also block, so I don't think this helps. INLINE COMMENTS > recentusagemodel.cpp:252 > +// taken from kfileitem::isSlow > +const KFileSystemType::Type fsType = >

D23198: Skip mime type check only for files on network mounts

meven created this revision. meven added reviewers: Plasma, dfaure. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Related diff D19784 BUG: 401579 REPOSITORY R119