D23274: [WIP] Add "Show intro page" button to System Settings sidebar

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM! REPOSITORY R124 System Settings BRANCH arcpatch-D23274 REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg, ngraham Cc: ngraham, mart, #vdg,

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

mart updated this revision to Diff 66806. mart added a comment. - correctly hide subcat column REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23274?vs=66780=66806 BRANCH arcpatch-D23274 REVISION DETAIL https://phabricator.kde.org/D23274

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

ngraham added a comment. Yep, I figured you could figure that part out. :) REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 added a comment. In D23274#537221 , @ngraham wrote: > Try this patch to your patch: P471 Addendum to D23274 Thanks! The only issue that's left now is that the subcategory doesn't get reset (when

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 updated this revision to Diff 66780. GB_2 added a comment. Use Nate's fix and enable button when clicking a most used item REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23274?vs=64682=66780 BRANCH

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

ngraham added a comment. Try this patch to your patch: P471 Addendum to D23274 REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n,

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 added a comment. Looks like this is more complicated than I thought. If someone wants to comandeer this revision then please do. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg Cc: ngraham, mart, #vdg, plasma-devel,

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 planned changes to this revision. GB_2 added a comment. I'll try to work more on this in the future. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n,

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

mart added a comment. any updates on this? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

mart added a comment. In D23274#520185 , @GB_2 wrote: > In D23274#520127 , @mart wrote: > > > SidebarMode::setActiveCategory may need to be modified to make it like it tough > > > Looks like

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 added a comment. In D23274#520127 , @mart wrote: > SidebarMode::setActiveCategory may need to be modified to make it like it tough Looks like it. INLINE COMMENTS > SidebarMode.cpp:498 > +if (introPageVisible) { > +

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

mart added a comment. SidebarMode::setActiveCategory may need to be modified to make it like it tough REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev,

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

mart added a comment. In D23274#519661 , @GB_2 wrote: > This is what happens when you set the current index to -1: F7282553: System Settings Sidebar Show Intro Page Button Bug.png did you also try

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 marked 2 inline comments as done. GB_2 added a comment. This is what happens when you set the current index to -1: F7282553: System Settings Sidebar Show Intro Page Button Bug.png REPOSITORY R124 System Settings REVISION DETAIL

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 updated this revision to Diff 64682. GB_2 added a comment. Use a bool property setter and disable button when on intro page REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23274?vs=64071=64682 BRANCH

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

ngraham added inline comments. INLINE COMMENTS > mart wrote in CategoriesPage.qml:71 > I would prefer overflow-menu This is just moving the existing item around, which already uses the hamburger menu icon (appropriately IMO). REPOSITORY R124 System Settings REVISION DETAIL

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

mart added a comment. there *may* be some changes needing to be done on SidebarMode::setActiveCategory for that to work, but try to do that, then wel'll see REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg Cc: mart, #vdg,

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

mart added a comment. when the intro page gets shown, (again binded from a bool property arriving from c++) categoryView.currentIndex should be set to -1, and systemsettings.activeCategory to -1 as well INLINE COMMENTS > SidebarMode.cpp:424 > > +void SidebarMode::showIntroPage() > +{

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 added a subscriber: mart. GB_2 added a comment. @mart can you help here? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg Cc: mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 405956 F7262289: System Settings Sidebar Show Intro Page Button.png