D23298: Unify busy spinner appearance on update page

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Abandoning in favor of the vastly superior D23357 
.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D23298

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23298: Unify busy spinner appearance on update page

[Nathaniel Graham]

ngraham added a comment.


  If there's a way to show an actual progress indicator in a way that ensures 
its accuracy, that would be much better, yeah. I'll be happy to abandon this 
patch if you can do that (I don't know how, sorry).

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D23298

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23298: Unify busy spinner appearance on update page

[Aleix Pol Gonzalez]

apol added a comment.


  As is, it looks unfinished to me. I prefer to give some kind of hint of 
what's happening, especially since this could take a while, yesterday I opened 
one laptop after a month (neon git unstable) or so and it took easily a minute 
to show anything there.
  In fact, we could look into showing progress here, which is what I wanted 
looking at the thing spin to no end.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D23298

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23298: Unify busy spinner appearance on update page

[Nathaniel Graham]

ngraham added a comment.


  All it used to say was "Fetching updates..." which I think is adequately 
implied by it being a busy spinner on the Updates page. The spinner on the main 
page doesn't say, "Fetching applications" or whatever, so I was trying to be 
consistent with that. Your call though.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D23298

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23298: Unify busy spinner appearance on update page

[Aleix Pol Gonzalez]

apol added a comment.


  We don't want any text?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D23298

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23298: Unify busy spinner appearance on update page

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Discover Software Store, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The busy spinner on the main page is in the center of the view. Let's do the 
same thing
  on the updates page. As part of this, we can get rid of the "Fetching 
updates..." text,
  because it's already perfectly clear what's going on.

TEST PLAN
  F7264935: Spinner.webm 

REPOSITORY
  R134 Discover Software Store

BRANCH
  unify-busy-spinners (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23298

AFFECTED FILES
  discover/qml/UpdatesPage.qml

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart