D23330: Make manual control compatible with redshift >= 1.12

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R885:898c3a4cfc6c: Make manual control compatible with 
redshift = 1.12 (authored by vermeeren, committed by ngraham).

REPOSITORY
  R885 Redshift Control for Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23330?vs=64263=68101

REVISION DETAIL
  https://phabricator.kde.org/D23330

AFFECTED FILES
  package/contents/ui/CompactRepresentation.qml

To: vermeeren, martinkostolny, #plasma, mart
Cc: mart, ltoscano, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D23330: Make manual control compatible with redshift >= 1.12

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  lgtm

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D23330

To: vermeeren, martinkostolny, #plasma, mart
Cc: mart, ltoscano, ngraham, plasma-devel, crossi, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D23330: Make manual control compatible with redshift >= 1.12

[Melvin Vermeeren]

vermeeren added a comment.


  In D23330#542544 , @ltoscano wrote:
  
  > Also, does this change superceded both D14068 
, D14245 
 and D23401 
 ?
  
  
  Yes, unlike those this one doesn't break old redshift < 1.12.

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D23330

To: vermeeren, martinkostolny, #plasma
Cc: ltoscano, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23330: Make manual control compatible with redshift >= 1.12

[Luigi Toscano]

ltoscano added a comment.


  Also, does this change superceded both D14068 
, D14245 
 and D23401 
 ?

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D23330

To: vermeeren, martinkostolny, #plasma
Cc: ltoscano, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23330: Make manual control compatible with redshift >= 1.12

[Melvin Vermeeren]

vermeeren added a comment.


  Is there any news regarding this? The updated diff has been tested (both 
version paths) and works properly. It should be ready for merge as is, and will 
close a bug over a year old. Urgency is rather high in my opinion, as both 
Debian >= buster and Ubuntu >= cosmic are shipping redshift 1.12 meaning this 
bug is now reaching end users in stable production systems.

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D23330

To: vermeeren, martinkostolny, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23330: Make manual control compatible with redshift >= 1.12

[Melvin Vermeeren]

vermeeren added a comment.


  In D23330#516238 , @ngraham wrote:
  
  > Is `redshift -P -O` fully backwards-compatible with older versions of 
redshift? If not, then this will just break everyone not using >=1.12.
  
  
  I checked and this is not the case, previous versions will error because of 
the unknown option. Updated the patch so it adds `-P` only for >= 1.12.

REVISION DETAIL
  https://phabricator.kde.org/D23330

To: vermeeren, martinkostolny, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23330: Make manual control compatible with redshift >= 1.12

[Melvin Vermeeren]

vermeeren updated this revision to Diff 64263.
vermeeren added a comment.


  Only add -P option for redshift >= 1.12, avoids breaking redshift < 1.12.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23330?vs=64249=64263

REVISION DETAIL
  https://phabricator.kde.org/D23330

AFFECTED FILES
  package/contents/ui/CompactRepresentation.qml

To: vermeeren, martinkostolny, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23330: Make manual control compatible with redshift >= 1.12

[Nathaniel Graham]

ngraham added a comment.


  Is `redshift -P -O` fully backwards-compatible with older versions of 
redshift? If not, then this will just break everyone not using >=1.12.

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D23330

To: vermeeren, martinkostolny, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23330: Make manual control compatible with redshift >= 1.12

[Melvin Vermeeren]

vermeeren added a comment.


  I am not sure how the version scheme will work now that this plasmoid is 
officially part of KDE, but once this is merged the version should definitely 
be bumped as this is a critical issue preventing use of manual mode. See also: 
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=910901

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D23330

To: vermeeren, martinkostolny
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23330: Make manual control compatible with redshift >= 1.12

[Melvin Vermeeren]

vermeeren created this revision.
vermeeren added a reviewer: martinkostolny.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
vermeeren requested review of this revision.

REVISION SUMMARY
  BUG: 395641
  
  Redshift version >= 1.12 requires the -P option to clear the existing gamma 
ramps for one-shot mode. Without it the screen gets darker and darker until it 
is impossible to see anything.
  
  Quoting from the redshift 1.12 manual page:
  
  > -O TEMP One-shot manual mode (set color temperature).  Use this with the -P 
option to clear the existing gamma ramps before applying the new color 
temperature.
  >  -P Reset existing gamma ramps before applying new color effect.

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D23330

AFFECTED FILES
  package/contents/ui/main.qml

To: vermeeren, martinkostolny
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart