D23651: WIP: Add support for a theming in Kicker Dashboard

2019-09-04 Thread Nathaniel Graham
ngraham added a comment. As a general concept, are we sure this makes sense? This is an overlay dashboard. It seems like it's supposed to always be dark. Making it respect the color scheme produces a result that, to be honest, I don't think works. The proposed light theme version has a

D23651: WIP: Add support for a theming in Kicker Dashboard

2019-09-04 Thread Filip Fila
filipf added a comment. I would also think a bit more about using Kirigami.SearchField -> it's not used in Kickoff and it's not properly themable (the same way PlasmaComponents.TextField is). It also looks too small. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D23651: WIP: Add support for a theming in Kicker Dashboard

2019-09-04 Thread Filip Fila
filipf added a comment. What I'm seeing is that this could result in poor visibility of action buttons. F7317401: image.png They should use text color. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23651 To:

D23651: WIP: Add support for a theming in Kicker Dashboard

2019-09-02 Thread David Redondo
davidre added a comment. The reason it's transparent is because the clear color of the buffer is set to the background color when it's changed [1][2]. This worked before probably because the Color was (0, 0, 0). For transparent windows we need to set it to `Qt::transparent`[3] and enable

D23651: WIP: Add support for a theming in Kicker Dashboard

2019-09-02 Thread Felix Ernst
felixernst added a comment. Current (?) one for comparison (from Kubuntu 18.04 since the one from Neon Unstable crashes for me) F7308896: Screenshot_20190902_143551.png I feel like there was a lot of thought put into the current design of the

D23651: WIP: Add support for a theming in Kicker Dashboard

2019-09-01 Thread Carl Schwan
ognarb created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. REVISION SUMMARY - Replace hardcoded color with Kirigami.Theme.* - Replace search bar with Kirigami.Search I tried to use PlasmaCore.Theme but