D23714: Manipulate Document prototype for createElement

2019-09-04 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R856:a83d9300a7a1: Manipulate Document prototype for 
createElement (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23714?vs=65359=65361

REVISION DETAIL
  https://phabricator.kde.org/D23714

AFFECTED FILES
  extension/content-script.js

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23714: Manipulate Document prototype for createElement

2019-09-04 Thread Carl Schwan 
ognarb accepted this revision.
ognarb added a comment.


  Tested in a modern browser and it still works

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23714

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23714: Manipulate Document prototype for createElement

2019-09-04 Thread Fabian Vogt 
fvogt accepted this revision.
fvogt added a comment.
This revision is now accepted and ready to land.


  The same approach should probably be used for other overrides as well, like 
`navigator.mediaSession.setActionHandler` and `window.Audio`. That's unrelated 
to the bug though.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23714

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23714: Manipulate Document prototype for createElement

2019-09-04 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, fvogt, ognarb.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This fixes Shadydom SHIM breaking because we overrode `createElement` and 
then the metadata it adds go missing, breaking websites.
  
  BUG: 411556

TEST PLAN
  (Sorry, patch directly from suse VM so I could test in Firefox ESR :D)
  
  - Firefox ESR 60 now has working Polymer (tested with Brightspace demo page)
  - Firefox ESR 60 document.createElement("audio") stuff still working well
  - Firefox ESR 60 "new Audio()" audio (e.g. Google Translate) still working 
well
  
  - Test in newer browsers pending

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23714

AFFECTED FILES
  extension/content-script.js

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart