D23799: Get rid of khtml usage (kill classic mode)

[Aleksei Midenkov]

midenok added a comment.


  Nice job of degradation!

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23799

To: svuorela, vkrause, plasma-devel, #plasma, bcooksley, gladhorn
Cc: midenok, gladhorn, nicolasfella, broulik, davidedmundson, ognarb, ngraham, 
#plasma, GB_2, sitter, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23799: Get rid of khtml usage (kill classic mode)

[Sune Vuorela]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:03892b3b0dc7: Get rid of khtml usage (kill classic mode) 
(authored by svuorela).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23799?vs=65675=65737

REVISION DETAIL
  https://phabricator.kde.org/D23799

AFFECTED FILES
  CMakeLists.txt
  classic/CMakeLists.txt
  classic/CategoryList.cpp
  classic/CategoryList.h
  classic/ClassicMode.cpp
  classic/ClassicMode.h
  classic/configClassic.ui
  classic/main.html
  classic/settings-classic-view.desktop
  classic/systemsettings-classic.css
  systemsettings.categories

To: svuorela, vkrause, plasma-devel, #plasma, bcooksley, gladhorn
Cc: gladhorn, nicolasfella, broulik, davidedmundson, ognarb, ngraham, #plasma, 
GB_2, sitter, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D23799: Get rid of khtml usage (kill classic mode)

[Frederik Gladhorn]

gladhorn accepted this revision.
gladhorn added a comment.
This revision is now accepted and ready to land.


  Based on all the +1s, this should clearly go in. Go for it :)

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23799

To: svuorela, vkrause, plasma-devel, #plasma, bcooksley, gladhorn
Cc: gladhorn, nicolasfella, broulik, davidedmundson, ognarb, ngraham, #plasma, 
GB_2, sitter, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D23799: Get rid of khtml usage (kill classic mode)

[Nicolas Fella]

nicolasfella added a comment.


  +1

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23799

To: svuorela, vkrause, plasma-devel, #plasma, bcooksley
Cc: nicolasfella, broulik, davidedmundson, ognarb, ngraham, #plasma, GB_2, 
sitter, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23799: Get rid of khtml usage (kill classic mode)

[Kai Uwe Broulik]

broulik added a comment.


  +1

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23799

To: svuorela, vkrause, plasma-devel, #plasma, bcooksley
Cc: broulik, davidedmundson, ognarb, ngraham, #plasma, GB_2, sitter, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23799: Get rid of khtml usage (kill classic mode)

[David Edmundson]

davidedmundson added a comment.


  +1  as the new sidebar is very similar IMHO.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23799

To: svuorela, vkrause, plasma-devel, #plasma, bcooksley
Cc: davidedmundson, ognarb, ngraham, #plasma, GB_2, sitter, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23799: Get rid of khtml usage (kill classic mode)

[Volker Krause]

vkrause added a comment.


  In D23799#527953 , @ognarb wrote:
  
  > +1
  >  is there a task somewhere where we can track all the KDE projects still  
using khtml?
  
  
  T11542  tracks KHTML specifically, and 
it's part of the larger KF6 workboard for tracking other such legacy 
dependencies.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23799

To: svuorela, vkrause, plasma-devel, #plasma
Cc: ognarb, ngraham, #plasma, GB_2, sitter, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23799: Get rid of khtml usage (kill classic mode)

[Carl Schwan]

ognarb added a comment.


  +1
  is there a task somewhere where we can track all the KDE projects still  
using khtml?

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23799

To: svuorela, vkrause, plasma-devel, #plasma
Cc: ognarb, ngraham, #plasma, GB_2, sitter, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23799: Get rid of khtml usage (kill classic mode)

[Nathaniel Graham]

ngraham added a comment.


  +1

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23799

To: svuorela, vkrause, plasma-devel, #plasma
Cc: ngraham, #plasma, GB_2, sitter, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23799: Get rid of khtml usage (kill classic mode)

[Björn Feber]

GB_2 added a comment.


  +1, let's also focus on fixing bugs for the other two views.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23799

To: svuorela, vkrause, plasma-devel
Cc: GB_2, sitter, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D23799: Get rid of khtml usage (kill classic mode)

[Volker Krause]

vkrause added a comment.


  +1

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23799

To: svuorela, vkrause, plasma-devel
Cc: sitter, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D23799: Get rid of khtml usage (kill classic mode)

[Harald Sitter]

sitter added a comment.


  +1

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23799

To: svuorela, vkrause, plasma-devel
Cc: sitter, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D23799: Get rid of khtml usage (kill classic mode)

[Sune Vuorela]

svuorela created this revision.
svuorela added reviewers: vkrause, plasma-devel.
Herald added a project: Plasma.
svuorela requested review of this revision.

REVISION SUMMARY
  khtml is going away, so remove the classic mode that relies on it

TEST PLAN
  It's optional, so it can go without much being lost

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23799

AFFECTED FILES
  CMakeLists.txt
  classic/CMakeLists.txt
  classic/CategoryList.cpp
  classic/CategoryList.h
  classic/ClassicMode.cpp
  classic/ClassicMode.h
  classic/configClassic.ui
  classic/main.html
  classic/settings-classic-view.desktop
  classic/systemsettings-classic.css
  systemsettings.categories

To: svuorela, vkrause, plasma-devel
Cc: LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart