D24008: Make renderDialGroove() area match the maximum renderDialContents() area

hpereiradacosta added a comment. on the other hand, after checking that the dials keep the old appearance when "wrapping" is turned on, and since dials are rather seldom used anyway, I have no strong feeling against the change (still prefer the old look though) REPOSITORY R31 Breeze

D24008: Make renderDialGroove() area match the maximum renderDialContents() area

hpereiradacosta added a comment. Problem with the new design if you ask me is that it does not convey the information that you can roll around past the maximum as in a circle anymore. All other widget styles (except now breeze), use a circle metaphor for a dial ... Personally I think the

D24008: Make renderDialGroove() area match the maximum renderDialContents() area

This revision was automatically updated to reflect the committed changes. Closed by commit R31:8e63d4509267: Make renderDialGroove() area match the maximum renderDialContents() area (authored by ndavis). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE

D24008: Make renderDialGroove() area match the maximum renderDialContents() area

ndavis updated this revision to Diff 66312. ndavis added a comment. Remove extra declaration of `first` REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24008?vs=66264=66312 BRANCH dial1 (branched from master) REVISION DETAIL

D24008: Make renderDialGroove() area match the maximum renderDialContents() area

ndavis added a comment. In D24008#532936 , @ngraham wrote: > Doesn't this mean that the visual appearance of the dial will change depending on what the maximum value is? No, you can apply this patch and apply whatever maximum value you

D24008: Make renderDialGroove() area match the maximum renderDialContents() area

ngraham added a comment. Doesn't this mean that the visual appearance of the dial will change depending on what the maximum value is? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24008 To: ndavis, #vdg, #breeze Cc: ngraham, plasma-devel, LeGast00n,

D24008: Make renderDialGroove() area match the maximum renderDialContents() area

ndavis created this revision. ndavis added reviewers: VDG, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY It bothered me that the groove for dials doesn't match the maximum area that the contents can