D24363: Fix several build system errors

2019-10-04 Thread Alexey Min 
This revision was automatically updated to reflect the committed changes.
Closed by commit R858:731b85008c21: Fix several build system errors (authored 
by alexeymin).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24363?vs=67233=67314

REVISION DETAIL
  https://phabricator.kde.org/D24363

AFFECTED FILES
  CMakeLists.txt
  plugin/CMakeLists.txt

To: alexeymin, mart, #plasma, dfaure
Cc: cgiboudeaux, kde-frameworks-devel, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24363: Fix several build system errors

2019-10-02 Thread Alexey Min 
alexeymin marked an inline comment as done.
alexeymin added a comment.


  Right, so I was fooled by having qqc2-desktop-style listed as Tier 1 on our 
main documentation page https://api.kde.org/frameworks/index.html . If it is 
really Tier 3, then maybe it does not even make sense to make IconThemes and 
ConfigWidgets optional?
  
  > The subgroup value looks wrong
  
  And maybe should I include a change to `mtainfo.yaml` modifying `subgroup: 
Tier 1` to `subgroup: Tier 3` then?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D24363

To: alexeymin, mart, #plasma, dfaure
Cc: cgiboudeaux, kde-frameworks-devel, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24363: Fix several build system errors

2019-10-02 Thread Alexey Min 
alexeymin updated this revision to Diff 67233.
alexeymin added a comment.


  - Bring back missing KF5_DEP_VERSION

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24363?vs=67207=67233

BRANCH
  alexeymin/fix-cmake-errors

REVISION DETAIL
  https://phabricator.kde.org/D24363

AFFECTED FILES
  CMakeLists.txt
  plugin/CMakeLists.txt

To: alexeymin, mart, #plasma, dfaure
Cc: cgiboudeaux, kde-frameworks-devel, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24363: Fix several build system errors

2019-10-02 Thread Christophe Giboudeaux 
cgiboudeaux added a comment.


  Note: the metainfo file says this framework is tier 3.
  
  The subgroup value looks wrong

INLINE COMMENTS

> CMakeLists.txt:40-41
> +# IconThemes and ConfigWidgets are optional
> +find_package(KF5IconThemes)
> +find_package(KF5ConfigWidgets)
>  

KF5_DEP_VERSION is lost here

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D24363

To: alexeymin, mart, #plasma, dfaure
Cc: cgiboudeaux, kde-frameworks-devel, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24363: Fix several build system errors

2019-10-02 Thread Alexey Min 
alexeymin reopened this revision.
alexeymin added a comment.


  Phabricator, you're drunk, it is not pushed to master

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D24363

To: alexeymin, mart, #plasma, dfaure
Cc: kde-frameworks-devel, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24363: Fix several build system errors

2019-10-02 Thread Phabricator 
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R858:9ddd3ba2f531: qqc2-desktop-style: Fix several builsystem 
errors (authored by Aleksey Minnekhanov 
aleksei.minneha...@myoffice.team).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24363?vs=67188=67207

REVISION DETAIL
  https://phabricator.kde.org/D24363

AFFECTED FILES
  CMakeLists.txt
  plugin/CMakeLists.txt

To: alexeymin, mart, #plasma, dfaure
Cc: kde-frameworks-devel, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart