D24407: Increase UI commonality between KCM and applet

This revision was automatically updated to reflect the committed changes. Closed by commit R115:fb5631928121: Increase UI commonality between KCM and applet (authored by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D24407: Increase UI commonality between KCM and applet

sefaeyeoglu accepted this revision. sefaeyeoglu added a comment. This revision is now accepted and ready to land. In D24407#544728 , @ngraham wrote: > I had a feeling. I say let's land this, then fix that. Do you agree? No objections 

D24407: Increase UI commonality between KCM and applet

ngraham added a comment. I had a feeling. I say let's land this, then fix that. Do you agree? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D24407 To: ngraham, #vdg, #plasma, drosca, broulik, sitter, sefaeyeoglu Cc: nicolasfella, ndavis, GB_2,

D24407: Increase UI commonality between KCM and applet

sefaeyeoglu added a comment. In D24407#544715 , @ngraham wrote: > In D24407#544714 , @sefaeyeoglu wrote: > > > In D24407#544707 , @ngraham wrote: > >

D24407: Increase UI commonality between KCM and applet

ngraham added a comment. In D24407#544714 , @sefaeyeoglu wrote: > In D24407#544707 , @ngraham wrote: > > > That should be fixed by D24402 , in plasma-framework.

D24407: Increase UI commonality between KCM and applet

sefaeyeoglu added a comment. In D24407#544707 , @ngraham wrote: > That should be fixed by D24402 , in plasma-framework. Can you verify that it's fixed if you apply that or build plasma-framework from master?

D24407: Increase UI commonality between KCM and applet

ngraham added a comment. That should be fixed by D24402 , in plasma-framework. Can you verify that it's fixed if you apply that or build plasma-framework from master? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL

D24407: Increase UI commonality between KCM and applet

sefaeyeoglu added a comment. Nice work! It looks very good now. One odd thing I just noticed: F7566825: plasma-pa-duplicate-defualt.mp4 REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D24407 To:

D24407: Increase UI commonality between KCM and applet

ngraham added a comment. Thanks for testing that, @sefaeyeoglu. I don't actually have a combination of devices that makes the combobox appear so that's much appreciated. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D24407 To: ngraham, #vdg,

D24407: Increase UI commonality between KCM and applet

ngraham updated this revision to Diff 67610. ngraham added a comment. Fix overflow in the applet and poor alignment in the KCM when the combobox is visible REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24407?vs=67293=67610 BRANCH

D24407: Increase UI commonality between KCM and applet

sefaeyeoglu added a comment. F7566730: 1570716308.png Looks like replacing the label with a combobox breaks alignment in the KCM and exceeds the full width in the applet. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL

D24407: Increase UI commonality between KCM and applet

sitter added a subscriber: nicolasfella. sitter added a comment. @nicolasfella do you have thoughts? The code looks fine, but then I don't really do qml on a daily basis. Visually I find the applet crowded, but maybe that's just me. REPOSITORY R115 Plasma Audio Volume Applet REVISION

D24407: Increase UI commonality between KCM and applet

ngraham added a comment. Ping. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D24407 To: ngraham, #vdg, #plasma, drosca, broulik, sitter, sefaeyeoglu Cc: ndavis, GB_2, mmustac, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D24407: Increase UI commonality between KCM and applet

ngraham added subscribers: GB_2, ndavis. ngraham added a comment. In D24407#541824 , @mmustac wrote: > Not related to this patch, but... > While looking at these screenshots I find it not self-explaining but more confusing that both buttons

D24407: Increase UI commonality between KCM and applet

mmustac added a comment. Not related to this patch, but... While looking at these screenshots I find it not self-explaining but more confusing that both buttons look the same, except one of them is in "active" state. I would propose to change the icon for the non-default device to an

D24407: Increase UI commonality between KCM and applet

ngraham updated this revision to Diff 67293. ngraham added a comment. Correct porting error in KCM combobox model generation REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24407?vs=67292=67293 BRANCH

D24407: Increase UI commonality between KCM and applet

ngraham created this revision. ngraham added reviewers: VDG, Plasma, drosca, broulik, sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch beings the user interface of the applet and the KCM