D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6b4295b313af: [applets/taskmanager] Revert forceStripes checkbox string change (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

aspotashev added a comment. Before pushing new i18n strings into stable branches, you need to ask for permission in https://mail.kde.org/mailman/listinfo/kde-i18n-doc Altough one translator's approval is enough, writing to kde-i18n-doc is also important to notify the other translation

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

ngraham added a comment. @aspotashev is a translator and he's approved, so I'd say you're good to go. REPOSITORY R119 Plasma Desktop BRANCH revert-force-stripes-string-change (branched from master) REVISION DETAIL https://phabricator.kde.org/D24534 To: filipf, #plasma, #vdg,

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

filipf added a comment. Do we have a green light for 5.17.1? How do I tag the translators? REPOSITORY R119 Plasma Desktop BRANCH revert-force-stripes-string-change (branched from master) REVISION DETAIL https://phabricator.kde.org/D24534 To: filipf, #plasma, #vdg, aspotashev, ngraham

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

aspotashev added a comment. In D24534#544785 , @davidedmundson wrote: > Original commit: https://git.reviewboard.kde.org/r/123738/ > > (following it through quite a few renames) > > From what I can tell, it's akin to the direction

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

ngraham added a subscriber: jriddell. ngraham added a comment. FWIW Plasma 5.17 tars were already made so if we want this in Plasma 5.17.0, in addition to landing it on the stable branch, @jriddell will have to do some release magic to include it and you'll want to ping him about that.

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

aspotashev accepted this revision. aspotashev added a comment. The changes in messages are indeed reverted by this patch. REPOSITORY R119 Plasma Desktop BRANCH revert-force-stripes-string-change (branched from master) REVISION DETAIL https://phabricator.kde.org/D24534 To: filipf,

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

ngraham added a comment. Idea for a better string: "Fill each row/column before adding tasks to the next row/column" REPOSITORY R119 Plasma Desktop BRANCH revert-force-stripes-string-change (branched from master) REVISION DETAIL https://phabricator.kde.org/D24534 To: filipf,

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks David, that's very helpful. Let's revert this in Plasma 5.17 for now (if translators approve) and work on a better string (or even a better UI) for Plasma 5.18. REPOSITORY R119

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

davidedmundson added a comment. Original commit: https://git.reviewboard.kde.org/r/123738/ (following it through quite a few renames) From what I can tell, it's akin to the direction property in a Flow REPOSITORY R119 Plasma Desktop REVISION DETAIL

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

ngraham added a comment. After playing around with this option with my IOTM at various panel widths and various "maximum rows/columns" values, I still cannot for the life of me figure out what on earth it does--or else the feature is so buggy I'm unable to discover the pattern. REPOSITORY

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

filipf added a comment. In D24534#544703 , @ngraham wrote: > "rows of as many columns" > > I'm afraid I still have no idea what this means! :) Can you explain what it actually does? Then maybe we can come up with a clear string together.

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

ngraham added a comment. "rows of as many columns" I'm afraid I still have no idea what this means! :) Can you explain what it actually does? Then maybe we can come up with a clear string together. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24534

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

filipf added a subscriber: ngraham. filipf added a comment. I still think the string could be improved some, maybe @ngraham has an idea. But the question is can this land in 5.17 given it's a string change? (albeit just a revert) REPOSITORY R119 Plasma Desktop REVISION DETAIL

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY I changed the "forceStripes" checkbox string in D19280 , most likey because I thought it wasn't