D24603: Port away from deprecated KDELibs4Support

2019-10-13 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R103:e3b8910670e3: Port away from deprecated KDELibs4Support (authored by ahmadsamir). REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24603?vs=67820=67831

D24603: Port away from deprecated KDELibs4Support

2019-10-13 Thread Volker Krause
vkrause accepted this revision. vkrause added a comment. Thanks! REPOSITORY R103 KMenu Editor BRANCH master REVISION DETAIL https://phabricator.kde.org/D24603 To: ahmadsamir, mlaurent, vkrause Cc: vkrause, plasma-devel, kde-frameworks-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24603: Port away from deprecated KDELibs4Support

2019-10-12 Thread Ahmad Samir
ahmadsamir added a comment. F7582001: kmenuedit-vs-dolphin-settings-dialog.png Looking at kmenuedit and dolphin settings dialog, the margin and spacing look comparable, so those setContentMargins and setSpacing calls aren't needed any more.

D24603: Port away from deprecated KDELibs4Support

2019-10-12 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added a reviewer: mlaurent. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahmadsamir requested review of this revision. REVISION SUMMARY kmenuedit seems to work, adding new submenus and items REPOSITORY R103 KMenu Editor