D24727: Fix NOAA picture of the day provider

2019-10-18 Thread Phabricator 
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:432470576605: Fix NOAA picture of the day provider 
(authored by Guo Yunhe ).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24727?vs=68225&id=68242

REVISION DETAIL
  https://phabricator.kde.org/D24727

AFFECTED FILES
  dataengines/potd/noaaprovider.cpp
  dataengines/potd/noaaprovider.h

To: guoyunhe, #plasma, sitter
Cc: sitter, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24727: Fix NOAA picture of the day provider

2019-10-18 Thread Harald Sitter 
sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  works well enough it seems
  F7622741: yJIMcaK.jpg 

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24727

To: guoyunhe, #plasma, sitter
Cc: sitter, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24727: Fix NOAA picture of the day provider

2019-10-18 Thread Nathaniel Graham 
ngraham added a comment.


  If it works for you @sitter then feel free to ignore me. But I believe my 
testing methodology is sound: I'm living in my built-from-source plasma session 
and I apply the patch, build and install kdeplasma-addons to `~/kde/usr`, and 
then restart plasmashell. This works for testing everything else.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24727

To: guoyunhe, #plasma
Cc: sitter, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24727: Fix NOAA picture of the day provider

2019-10-18 Thread Yunhe Guo 
guoyunhe updated this revision to Diff 68225.
guoyunhe added a comment.


  Validate QUrl of image

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24727?vs=68185&id=68225

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24727

AFFECTED FILES
  dataengines/potd/noaaprovider.cpp
  dataengines/potd/noaaprovider.h

To: guoyunhe, #plasma
Cc: sitter, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24727: Fix NOAA picture of the day provider

2019-10-18 Thread Harald Sitter 
sitter added a comment.


  When I put the code in a minimal standalone program I can confirm that the 
code works just fine. Are you sure your testing methodology is sound @ngraham ?
  
  In point of fact
  
if (url.isEmpty()) {
  
  should actually be `url.isValid` because the requirement is not just that it 
needs to be nonempty but also valid, and when changed that condition would show 
more clearly that the right code is run as the KIO warning should disappear.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24727

To: guoyunhe, #plasma
Cc: sitter, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24727: Fix NOAA picture of the day provider

2019-10-17 Thread Nathaniel Graham 
ngraham added a comment.


  I don't know what to tell you; it's still broken for me. It looks like the 
first part of the URL isn't getting added onto the second, maybe.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24727

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24727: Fix NOAA picture of the day provider

2019-10-17 Thread Yunhe Guo 
guoyunhe added a comment.


  In D24727#549327 , @ngraham wrote:
  
  > Still broken, I'm afraid. Among the console output is the following, which 
may be helpful:
  >
  >   kf5.kio.core: Invalid URL: QUrl("/sites/default/files/bomb-cycle-1.jpg")
  >
  
  
  The url in my patch is `QStringLiteral("https://www.nesdis.noaa.gov";) + 
result.captured(1);`. So it must begin with `https://`.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24727

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24727: Fix NOAA picture of the day provider

2019-10-17 Thread Nathaniel Graham 
ngraham added a comment.


  Still broken, I'm afraid. Among the console output is the following, which 
may be helpful:
  
kf5.kio.core: Invalid URL: QUrl("/sites/default/files/bomb-cycle-1.jpg")

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24727

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24727: Fix NOAA picture of the day provider

2019-10-17 Thread Yunhe Guo 
guoyunhe updated this revision to Diff 68185.
guoyunhe edited the summary of this revision.
guoyunhe added a comment.


  Change back to the original page URL

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24727?vs=68126&id=68185

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24727

AFFECTED FILES
  dataengines/potd/noaaprovider.cpp
  dataengines/potd/noaaprovider.h

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24727: Fix NOAA picture of the day provider

2019-10-17 Thread Yunhe Guo 
guoyunhe added a comment.


  In D24727#549199 , @ngraham wrote:
  
  > This doesn't fix the problem for me. :(
  
  
  Can you run `plasmashell --replace` in terminal and check the error output?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24727

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24727: Fix NOAA picture of the day provider

2019-10-17 Thread Nathaniel Graham 
ngraham added a comment.


  This doesn't fix the problem for me. :(

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24727

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24727: Fix NOAA picture of the day provider

2019-10-17 Thread Yunhe Guo 
guoyunhe created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  The webpage structure of NOAA changed so the old regular expression doesn't 
work anymore. Updated it. But it can break in future again.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24727

AFFECTED FILES
  dataengines/potd/noaaprovider.cpp
  dataengines/potd/noaaprovider.h

To: guoyunhe
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart