D24740: [Media Controller] Multiple artists support

2019-10-18 Thread Ilya Katsnelson
K900 added a comment. Re: lockscreen/toolbar stuff: maybe the metadata parsing should go into the dataengine instead? I could write up a patch to move the metadata parsing logic there, and then we can have the actual QML bits refer to the specific parsed fields that will come pre-sanitized

D24740: [Media Controller] Multiple artists support

2019-10-18 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:1be4bb880fde: [Media Controller] Multiple artists support (authored by lesf0, committed by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24740: [Media Controller] Multiple artists support

2019-10-17 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > lesf0 wrote in main.qml:61 > That would make much more sence, but (at least for now) `QStringList` is > array-like object and not an actual `Array` instance, and I don't really feel > like I want to mess with all those "is-arrayish >

D24740: [Media Controller] Multiple artists support

2019-10-17 Thread Denis Sheremet
lesf0 added a comment. > Do you have commit access? If not, I need an E-Mail address so I can land this for you. I don't, you can add my email: me@lxlz.space > Bonus points if you also look at media controls in task manager (the ones when you hover a window):

D24740: [Media Controller] Multiple artists support

2019-10-17 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks for your patch! I am not sure if the property should be perhaps changed to a `property var` and always contain an `Array`. But that would mean changing the tooltip, full

D24740: [Media Controller] Multiple artists support

2019-10-17 Thread Denis Sheremet
lesf0 created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. lesf0 requested review of this revision. REVISION SUMMARY According to the spec, xesam:artist should be a string array, but majority of players uses string instead. This patch adds support