subject:"D24846\: Port kcm icons to kconfigxt"

D24846: Port kcm icons to kconfigxt

2019-12-31 Thread Benjamin Port

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:38ba450787ae: Port kcm icons to kconfigxt (authored by 
bport).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24846?vs=72189=72446#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24846?vs=72189=72446

REVISION DETAIL
  https://phabricator.kde.org/D24846

AFFECTED FILES
  kcms/icons/CMakeLists.txt
  kcms/icons/changeicons.cpp
  kcms/icons/iconsizecategorymodel.cpp
  kcms/icons/iconsizecategorymodel.h
  kcms/icons/iconsmodel.cpp
  kcms/icons/iconsmodel.h
  kcms/icons/iconssettings.cpp
  kcms/icons/iconssettings.h
  kcms/icons/iconssettingsbase.kcfg
  kcms/icons/iconssettingsbase.kcfgc
  kcms/icons/main.cpp
  kcms/icons/main.h
  kcms/icons/package/contents/ui/IconSizePopup.qml
  kcms/icons/package/contents/ui/main.qml

To: bport, ervin, mart, #plasma, crossi
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24846: Port kcm icons to kconfigxt

2019-12-26 Thread Benjamin Port

bport updated this revision to Diff 72189.
bport added a comment.


  Update according to ervin feedback

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24846?vs=71956=72189

REVISION DETAIL
  https://phabricator.kde.org/D24846

AFFECTED FILES
  kcms/icons/CMakeLists.txt
  kcms/icons/changeicons.cpp
  kcms/icons/iconsizecategorymodel.cpp
  kcms/icons/iconsizecategorymodel.h
  kcms/icons/iconsmodel.cpp
  kcms/icons/iconsmodel.h
  kcms/icons/iconssettings.cpp
  kcms/icons/iconssettings.h
  kcms/icons/iconssettingsbase.kcfg
  kcms/icons/iconssettingsbase.kcfgc
  kcms/icons/main.cpp
  kcms/icons/main.h
  kcms/icons/package/contents/ui/IconSizePopup.qml
  kcms/icons/package/contents/ui/main.qml

To: bport, ervin, mart, #plasma, crossi
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24846: Port kcm icons to kconfigxt

2019-12-23 Thread Kevin Ottens

ervin added a comment.


  Just a couple of stylistic issues left AFAICT

INLINE COMMENTS

> iconsmodel.h:47
>  public:
> -IconsModel(QObject *parent);
> +IconsModel(QObject *parent, IconsSettings *iconsSettings);
>  ~IconsModel() override;

Kind of a nitpick in this context, but parent should go last and default to 
nullptr. It's the Qt convention for QObject ctors.

> iconssettings.cpp:48
> +if (m_themeDirty)
> +{
> +KIconTheme::reconfigure();

The opening curly braces should be on the same line than the if

> main.cpp:135
>  m_model->load();
> -loadIconSizes();
> -m_model->setSelectedTheme(KIconTheme::current());
> -setNeedsSave(false);
> -m_selectedThemeDirty = false;
> -m_iconSizesDirty = false;
> +emit m_settings->ThemeChanged();
>  }

This one likely requires a comment, since normally you wouldn't need such an 
emit.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24846

To: bport, ervin, mart, #plasma, crossi
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24846: Port kcm icons to kconfigxt

2019-12-21 Thread Benjamin Port

bport updated this revision to Diff 71956.
bport added a comment.


  Remone unused include

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24846?vs=71668=71956

REVISION DETAIL
  https://phabricator.kde.org/D24846

AFFECTED FILES
  kcms/icons/CMakeLists.txt
  kcms/icons/changeicons.cpp
  kcms/icons/iconsizecategorymodel.cpp
  kcms/icons/iconsizecategorymodel.h
  kcms/icons/iconsmodel.cpp
  kcms/icons/iconsmodel.h
  kcms/icons/iconssettings.cpp
  kcms/icons/iconssettings.h
  kcms/icons/iconssettingsbase.kcfg
  kcms/icons/iconssettingsbase.kcfgc
  kcms/icons/main.cpp
  kcms/icons/main.h
  kcms/icons/package/contents/ui/IconSizePopup.qml
  kcms/icons/package/contents/ui/main.qml

To: bport, ervin, mart, #plasma, crossi
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24846: Port kcm icons to kconfigxt

2019-12-17 Thread Cyril Rossi

crossi added inline comments.

INLINE COMMENTS

> iconsmodel.cpp:29
>  #include 
> +#include 
>  

include not used

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24846

To: bport, ervin, mart, #plasma, crossi
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24846: Port kcm icons to kconfigxt

2019-12-16 Thread Benjamin Port

bport updated this revision to Diff 71668.
bport added a comment.


  Add theme to kconfigXT

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24846?vs=71127=71668

REVISION DETAIL
  https://phabricator.kde.org/D24846

AFFECTED FILES
  kcms/icons/CMakeLists.txt
  kcms/icons/changeicons.cpp
  kcms/icons/iconsizecategorymodel.cpp
  kcms/icons/iconsizecategorymodel.h
  kcms/icons/iconsmodel.cpp
  kcms/icons/iconsmodel.h
  kcms/icons/iconssettings.cpp
  kcms/icons/iconssettings.h
  kcms/icons/iconssettingsbase.kcfg
  kcms/icons/iconssettingsbase.kcfgc
  kcms/icons/main.cpp
  kcms/icons/main.h
  kcms/icons/package/contents/ui/IconSizePopup.qml
  kcms/icons/package/contents/ui/main.qml

To: bport, ervin, mart, #plasma, crossi
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24846: Port kcm icons to kconfigxt

2019-12-09 Thread Benjamin Port

bport updated this revision to Diff 71127.
bport marked 5 inline comments as done.
bport added a comment.


  Take in consideration ervin feedback

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24846?vs=71117=71127

REVISION DETAIL
  https://phabricator.kde.org/D24846

AFFECTED FILES
  kcms/icons/CMakeLists.txt
  kcms/icons/iconsizecategorymodel.cpp
  kcms/icons/iconsizecategorymodel.h
  kcms/icons/iconssettings.kcfg
  kcms/icons/iconssettings.kcfgc
  kcms/icons/main.cpp
  kcms/icons/main.h
  kcms/icons/package/contents/ui/IconSizePopup.qml

To: bport, ervin, mart, #plasma, crossi
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24846: Port kcm icons to kconfigxt

2019-12-09 Thread Benjamin Port

bport updated this revision to Diff 71117.
bport added a comment.


  Take in consideration feedbacks

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24846?vs=71110=71117

REVISION DETAIL
  https://phabricator.kde.org/D24846

AFFECTED FILES
  kcms/icons/CMakeLists.txt
  kcms/icons/iconssettings.kcfg
  kcms/icons/iconssettings.kcfgc
  kcms/icons/main.cpp
  kcms/icons/main.h
  kcms/icons/package/contents/ui/IconSizePopup.qml

To: bport, ervin, mart, #plasma, crossi
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24846: Port kcm icons to kconfigxt

2019-12-09 Thread Benjamin Port

bport updated this revision to Diff 71110.
bport added a comment.


  Fix

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24846?vs=70452=71110

REVISION DETAIL
  https://phabricator.kde.org/D24846

AFFECTED FILES
  kcms/icons/CMakeLists.txt
  kcms/icons/iconssettings.kcfg
  kcms/icons/iconssettings.kcfgc
  kcms/icons/main.cpp
  kcms/icons/main.h
  kcms/icons/package/contents/ui/IconSizePopup.qml

To: bport, ervin, mart, #plasma, crossi
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24846: Port kcm icons to kconfigxt

2019-11-29 Thread Kevin Ottens

ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.


  Looks like you didn't address a faire number of comments, or they ended up in 
the wrong commit (by the look of D24847 ).

INLINE COMMENTS

> main.cpp:137
>  {
> -return m_iconSizes[group];
> -}
> -
> -void IconModule::setIconSize(int group, int size)
> -{
> -if (iconSize(group) == size) {
> -return;
> +QString themeName(m_model->selectedTheme());
> +if (!m_kicon_theme_map.contains(m_model->selectedTheme())) {

nitpick, I find = more readable in such a context (and less prone to the most 
vexing parse since you don't use curly braces init).

I'd write: const auto themeName = m_model->selectedTheme();

> ervin wrote in main.cpp:102
> Now that my ManagedConfigModule change landed, you should use a proper 
> compile time check connect to settingsChanged here.

I still think those connects might not be necessary.

> ervin wrote in main.cpp:110
> Don't do foreach. Instead write:
> 
>   for (auto theme : qAsConst(m_iconThemeCache)) {
> 
> Or even better, just use qDeleteAll:
> 
>   qDeleteAll(m_iconThemeCache)
> 
> Or even better yet : try to use std::unique_ptr, std::shared_ptr or 
> QScopedPointer as values in your associative container (I let you check which 
> one fits best).

Still not addressed... mind your for loops...

> main.h:117
>  
> -QVector m_iconSizes;
> +QMap m_kicon_theme_map;
>  

Still not addressed... s/m_kicon_theme_map/m_iconThemeMap/ (we do camel case 
here) and should be a QHash.

> ervin wrote in main.h:34
> s/QMap/QHash/

Still not addressed, use a QHash

> ervin wrote in main.h:83
> Killing the const here is semantically wrong IMO.

Still not addressed, put the const back

> ervin wrote in IconSizePopup.qml:81
> I think I'd have expected that logic on the C++ side actually. Others might 
> disagree. :-)

Not on the C++ side still?

> ervin wrote in IconSizePopup.qml:91
> Urgh, I'd assert than silently swallow that I think.

Still not addressed

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24846

To: bport, ervin, mart, #plasma, crossi
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24846: Port kcm icons to kconfigxt

2019-11-27 Thread Benjamin Port

bport updated this revision to Diff 70452.
bport added a comment.


  Take in consideration feedback

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24846?vs=69036=70452

REVISION DETAIL
  https://phabricator.kde.org/D24846

AFFECTED FILES
  kcms/icons/CMakeLists.txt
  kcms/icons/iconssettings.kcfg
  kcms/icons/iconssettings.kcfgc
  kcms/icons/main.cpp
  kcms/icons/main.h
  kcms/icons/package/contents/ui/IconSizePopup.qml

To: bport, ervin, mart, #plasma, crossi
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24846: Port kcm icons to kconfigxt

2019-10-30 Thread Kevin Ottens

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> main.cpp:101
>  
> -connect(m_model, ::selectedThemeChanged, this, [this] {
> -m_selectedThemeDirty = true;
> -setNeedsSave(true);
> -});
> -connect(m_model, ::pendingDeletionsChanged, this, [this] {
> -setNeedsSave(true);
> -});
> +connect(m_model, SIGNAL(selectedThemeChanged()), this, 
> SLOT(_k_settingsChanged()));
> +connect(m_model, SIGNAL(pendingDeletionsChanged()), this, 
> SLOT(_k_settingsChanged()));

Shouldn't you be able to remove that connect? I'd expect this signal trickling 
down to changing the settings object, wouldn't it?

> main.cpp:102
> +connect(m_model, SIGNAL(selectedThemeChanged()), this, 
> SLOT(_k_settingsChanged()));
> +connect(m_model, SIGNAL(pendingDeletionsChanged()), this, 
> SLOT(_k_settingsChanged()));
>  

Now that my ManagedConfigModule change landed, you should use a proper compile 
time check connect to settingsChanged here.

> main.cpp:110
>  {
> +foreach (KIconTheme* theme, m_kicon_theme_map) {
> +delete theme;

Don't do foreach. Instead write:

  for (auto theme : qAsConst(m_iconThemeCache)) {

Or even better, just use qDeleteAll:

  qDeleteAll(m_iconThemeCache)

Or even better yet : try to use std::unique_ptr, std::shared_ptr or 
QScopedPointer as values in your associative container (I let you check which 
one fits best).

> main.cpp:137
>  {
> -return m_iconSizes[group];
> -}
> -
> -void IconModule::setIconSize(int group, int size)
> -{
> -if (iconSize(group) == size) {
> -return;
> +QString themeName(m_model->selectedTheme());
> +if (!m_kicon_theme_map.contains(m_model->selectedTheme())) {

nitpick, I find = more readable in such a context (and less prone to the most 
vexing parse since you don't use curly braces init).

I'd write: `const auto themeName = m_model->selectedTheme();`

> main.cpp:138
> +QString themeName(m_model->selectedTheme());
> +if (!m_kicon_theme_map.contains(m_model->selectedTheme())) {
> +m_kicon_theme_map.insert(themeName, new KIconTheme(themeName));

Couldn't you fill the cache as soon as the selected theme changes instead? This 
way you wouldn't need to modify your cache here.

> main.h:34
>  #include 
> +#include 
>  

s/QMap/QHash/

> main.h:83
>  
> -Q_INVOKABLE int iconSize(int group) const;
> -Q_INVOKABLE void setIconSize(int group, int size);
> -Q_INVOKABLE QList availableIconSizes(int group) const;
> +Q_INVOKABLE QList availableIconSizes(int group);
>  

Killing the const here is semantically wrong IMO.

> main.h:117
>  
> -QVector m_iconSizes;
> +QMap m_kicon_theme_map;
>  

You don't need the keys to be sorted, so please use QHash instead.

Also we do camel case here, not snake case. :-)

> IconSizePopup.qml:81
>  
> +property var sizesMap: [
> +{"settingName":"desktopSize", "displayName": 
> i18n("Desktop")},

I think I'd have expected that logic on the C++ side actually. Others might 
disagree. :-)

> IconSizePopup.qml:91
> +function sizeDisplayName(index) {
> +index = index <0 ? 0 : index;
> +return iconTypeList.sizesMap[index].displayName;

Urgh, I'd assert than silently swallow that I think.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24846

To: bport, ervin, mart, #plasma, crossi
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24846: Port kcm icons to kconfigxt

2019-10-30 Thread Benjamin Port

bport updated this revision to Diff 69036.
bport added a comment.


  Take in consideration feedback (cache kicon call)
  Port to ManagedConfigModule

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24846?vs=68498=69036

REVISION DETAIL
  https://phabricator.kde.org/D24846

AFFECTED FILES
  kcms/icons/CMakeLists.txt
  kcms/icons/iconssettings.kcfg
  kcms/icons/iconssettings.kcfgc
  kcms/icons/main.cpp
  kcms/icons/main.h
  kcms/icons/package/contents/ui/IconSizePopup.qml

To: bport, ervin, mart, #plasma, crossi
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24846: Port kcm icons to kconfigxt

2019-10-25 Thread Kevin Ottens

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> broulik wrote in main.cpp:141
> Does this `KIconTheme` instance need caching? I recall creating those parses 
> a tonne of files and directories and is quite slow

Agreed, it'll hit the disk quite a bit, this might be a problem in a function 
which takes part in bindings (more than one which will change around the same 
time).

> main.cpp:176
> +{
> +   return m_model->selectedTheme() != KIconTheme::current();
> +}

Indentation looks wrong here.

> bport wrote in IconSizePopup.qml:47-53
> I wiil look if I can simplify that

I like the intent of trying to have names instead of just indices everywhere... 
but that might not be feasible without extra complexity we'll want to avoid 
indeed.

I think the more fundamental problem is that the settings are based on those 
names, while the invokables (most notably availableIconSizes) are based on 
indices. Probably something to address, like have names everywhere and just a 
function to map from index to name in the iconTypeList.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24846

To: bport, ervin, mart, #plasma, crossi
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24846: Port kcm icons to kconfigxt

2019-10-22 Thread Benjamin Port

bport added inline comments.

INLINE COMMENTS

> broulik wrote in IconSizePopup.qml:45
> Do you not need to leave this (or a similar) connect in place?

This one is replaced (and that fix bug described above by call onVisibleChange)
and with kconfigxt property handling

> broulik wrote in IconSizePopup.qml:47-53
> I don't like this duplication, especially since sometimes you use 
> `currentIndex` and sometimes the `currentCategory`

I wiil look if I can simplify that

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24846

To: bport, ervin, mart, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24846: Port kcm icons to kconfigxt

2019-10-22 Thread Kai Uwe Broulik

broulik added inline comments.

INLINE COMMENTS

> main.cpp:141
>  {
> -return 
> KIconLoader::global()->theme()->querySizes(static_cast(group));
> +KIconTheme theme(m_model->selectedTheme());
> +return theme.querySizes(static_cast(group));

Does this `KIconTheme` instance need caching? I recall creating those parses a 
tonne of files and directories and is quite slow

> IconSizePopup.qml:45
> -target: kcm
> -onIconSizesChanged: iconSizeSlider.updateSizes()
>  }

Do you not need to leave this (or a similar) connect in place?

> IconSizePopup.qml:47-53
> +iconTypeList.currentCategory = [
> +"desktopSize",
> +"toolbarSize",
> +"mainToolbarSize",
> +"smallSize",
> +"panelSize",
> +"dialogSize"

I don't like this duplication, especially since sometimes you use 
`currentIndex` and sometimes the `currentCategory`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24846

To: bport, ervin, mart, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24846: Port kcm icons to kconfigxt

2019-10-22 Thread Benjamin Port

bport created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REVISION SUMMARY
  Also fix 2 bugs:
  
  - keyboard navigation on size category didn't work as expected, we didn't 
saved what we see
  
  (open size widget: arrow down, arrow right, save => will save the size to 
desktop entry instead of toolbar
  
  - the icon slider was not updated when we change theme

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24846

AFFECTED FILES
  kcms/icons/CMakeLists.txt
  kcms/icons/iconssettings.kcfg
  kcms/icons/iconssettings.kcfgc
  kcms/icons/main.cpp
  kcms/icons/main.h
  kcms/icons/package/contents/ui/IconSizePopup.qml

To: bport
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24846: Port kcm icons to kconfigxt

D24846: Port kcm icons to kconfigxt

D24846: Port kcm icons to kconfigxt

D24846: Port kcm icons to kconfigxt

D24846: Port kcm icons to kconfigxt

D24846: Port kcm icons to kconfigxt

D24846: Port kcm icons to kconfigxt

D24846: Port kcm icons to kconfigxt

D24846: Port kcm icons to kconfigxt

D24846: Port kcm icons to kconfigxt

D24846: Port kcm icons to kconfigxt

D24846: Port kcm icons to kconfigxt

D24846: Port kcm icons to kconfigxt

D24846: Port kcm icons to kconfigxt

D24846: Port kcm icons to kconfigxt

D24846: Port kcm icons to kconfigxt

D24846: Port kcm icons to kconfigxt

17 matches

Site Navigation

Mail list logo

Footer information