D24866: Wired setting: improve handling of link negotiation

jgrulich marked an inline comment as done. jgrulich added inline comments. INLINE COMMENTS > davidedmundson wrote in wiredconnectionwidget.cpp:79 > can loadConfig can be called multiple times? > > If so we need an explicit > > else { >setCurrentIndex(LinkNegotiation::Ignore); > } No,

D24866: Wired setting: improve handling of link negotiation

This revision was automatically updated to reflect the committed changes. jgrulich marked an inline comment as done. Closed by commit R116:8b9eb87388cc: Wired setting: improve handling of link negotiation (authored by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE

D24866: Wired setting: improve handling of link negotiation

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > wiredconnectionwidget.cpp:79 > +m_widget->linkNegotiation->setCurrentIndex(LinkNegotiation::Manual); > +} > can loadConfig can be called

D24866: Wired setting: improve handling of link negotiation

jgrulich added a comment. In D24866#569410 , @ngraham wrote: > UI looks good to me. Do you maybe want to review the code itself? It's not that complicated and nobody else seems to be interested. REPOSITORY R116 Plasma Network

D24866: Wired setting: improve handling of link negotiation

ngraham accepted this revision as: VDG. ngraham added a comment. UI looks good to me. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D24866 To: jgrulich, #plasma, #vdg Cc: ngraham, dvalter, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24866: Wired setting: improve handling of link negotiation

jgrulich added a comment. Ping? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D24866 To: jgrulich, #plasma Cc: dvalter, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin,

D24866: Wired setting: improve handling of link negotiation

dvalter added a comment. In D24866#558796 , @jgrulich wrote: > I did basically what nm-connection-editor allows you to do. I also found somewhere that half-duplex is in the specification even for 1Gbps. Valid point since NetworkManager

D24866: Wired setting: improve handling of link negotiation

jgrulich added a comment. In D24866#558545 , @dvalter wrote: > Looks like a complete fix to #413211 . I've tested it on Arch Linux with different modes. For me Ignore, Auto and 10/100/1000 Mbps modes

D24866: Wired setting: improve handling of link negotiation

dvalter added a comment. Looks like a complete fix to #413211 . I've tested it on Arch Linux with different modes. For me Ignore, Auto and 10/100/1000 Mbps modes worked as intended as well as duplex setup for 10 and 100. The only

D24866: Wired setting: improve handling of link negotiation

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY Adds option to ignore link-negotiation, also uses a combobox, similar to what nm-connection-editor is using, to give a choice