sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.
Oh it's gorgeous!
REPOSITORY
R871 DrKonqi
BRANCH
windowsystem (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D24890
To: davidre, sitter
Cc: apol, plasma-devel,
This revision was automatically updated to reflect the committed changes.
Closed by commit R871:8b8f813620b5: Report windowing system (authored by
davidre).
REPOSITORY
R871 DrKonqi
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24890?vs=68607=68608
REVISION DETAIL
davidre updated this revision to Diff 68607.
davidre added a comment.
report Unknown
REPOSITORY
R871 DrKonqi
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24890?vs=68604=68607
BRANCH
windowsystem (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D24890
sitter requested changes to this revision.
sitter added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> davidre wrote in CMakeLists.txt:30
> I don't know but I just moved the find_package WindowSystem out of the if
> because now it would be needed
davidre added inline comments.
INLINE COMMENTS
> CMakeLists.txt:30
> -Notifications IdleTime)
> -if(APPLE)
> -find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS WindowSystem)
I don't know but I just moved the find_package WindowSystem out of the if
because now it would be needed
apol added inline comments.
INLINE COMMENTS
> CMakeLists.txt:30
> -Notifications IdleTime)
> -if(APPLE)
> -find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS WindowSystem)
Do we know why this was done?
REPOSITORY
R871 DrKonqi
REVISION DETAIL
https://phabricator.kde.org/D24890
davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.
REVISION SUMMARY
Sometimes applications have different code paths for X11 or Wayland. Drkonqi
reporting that saves one "question -> wait for reply
