ngraham added a comment.
Landed this on the 5.17 branch just now to make sure it gets in for Plasma
5.17.2.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D24986
To: davidedmundson, #plasma, ngraham, davidre
Cc: davidre, plasma-devel, LeGast00n,
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:9dca7d6cd44c: [wallpapers/image] Randomise new batches of
images in the slideshow (authored by davidedmundson, committed by ngraham).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
davidre added a comment.
To clarify my comment refers to
> The logic is fine but if we start with 0 wallpapers and then add 20 newones
we don't shuffle anything.
For the other cases shuffling the added images is probably the right thing
REPOSITORY
R120 Plasma Workspace
BRANCH
davidre added a comment.
Are you sure? Shouldn't we be hitting this case:
https://cgit.kde.org/plasma-workspace.git/tree/wallpapers/image/image.cpp#n773 ?
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D24986
To: davidedmundson, #plasma,
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
There was a concious decision that when we add a new wallpaper we should
