D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:69d649e5aab4: [containments/desktop] Delete the 
Tweaks page and its options (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25055?vs=68997=69115

REVISION DETAIL
  https://phabricator.kde.org/D25055

AFFECTED FILES
  containments/desktop/package/contents/config/config.qml
  containments/desktop/package/contents/config/main.xml
  containments/desktop/package/contents/ui/ConfigTweaks.qml
  containments/desktop/package/contents/ui/main.qml

To: ngraham, mart, GB_2, #plasma, hein
Cc: fabianr, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Nathaniel Graham]

ngraham added a comment.


  Thanks for your flexibility, @mart. :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  delete-tweaks-page (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma, hein
Cc: fabianr, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Fabian Riethmayer]

fabianr added a comment.


  I would
  
  In D25055#557216 , @hein wrote:
  
  > If we want to keep the handles-on-hover outside of Edit Mode, is there a 
reason it can't be always on and needs to be gated behind a checkbox?
  >
  > I have to admit though I have a hard time seeing users like/rely on this 
behavior. Hovering and just waiting, even once you've learned it's possible, is 
always going to be an unsatisfying user experience - you're literally waiting 
around until the system deigns to approve your intent (long-press, in contrast 
is still //active// to some extent). I'd be worried that some users might learn 
"long hover" as "this is how it's supposed to be done" and then be forever 
annoyed that widgets are so cumbersome to handle. I'd propose removing it and 
fully leading users towards Edit Mode instead?
  
  
  +1
  And long hover is not something that would work with touch devices or is 
common in plasma or other environments, so I don't see a point in introducing a 
new usage pattern, that looks to me quiet cumbersome and problematic.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma, hein
Cc: fabianr, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Nathaniel Graham]

ngraham added a comment.


  In D25055#557216 , @hein wrote:
  
  > I have to admit though I have a hard time seeing users like/rely on this 
behavior. Hovering and just waiting, even once you've learned it's possible, is 
always going to be an unsatisfying user experience - you're literally waiting 
around until the system deigns to approve your intent (long-press, in contrast 
is still //active// to some extent). I'd be worried that some users might learn 
"long hover" as "this is how it's supposed to be done" and then be forever 
annoyed that widgets are so cumbersome to handle. I'd propose removing it and 
fully leading users towards Edit Mode instead?
  
  
  Exactly my thoughts.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma, hein
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Eike Hein]

hein added a comment.


  If we want to keep the handles-on-hover outside of Edit Mode, is there a 
reason it can't be always on and needs to be gated behind a checkbox?
  
  I have to admit though I have a hard time seeing users like/rely on this 
behavior. Hovering and just waiting, even once you've learned it's possible, is 
always going to be an unsatisfying user experience - you're literally waiting 
around until the system deigns to approve your intent (long-press, in contrast 
is still //active// to some extent). I'd be worried that some users might learn 
"long hover" as "this is how it's supposed to be done" and then be forever 
annoyed that widgets are so cumbersome to handle. I'd propose removing it and 
fully leading users towards Edit Mode instead?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma, hein
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Nathaniel Graham]

ngraham added a comment.


  Ahh, I wasn't hovering for long enough. I see it now.
  
  After finally understanding and using this feature, I really think we should 
discard it. Actually explaining it in the UI in a way that would make it 
comprehensible would require an incredibly wordy checkbox like
  
[] Show widget handles when hovering over widgets for a few seconds while 
outside of edit mode
  
  Also, what does it really gain us? "Long hover" is no faster than "long 
press" and less intuitive. I don't really see the gain.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma, hein
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Marco Martin]

mart added a comment.


  In D25055#556797 , @ngraham wrote:
  
  > In D25055#556755 , @mart wrote:
  >
  > > In D25055#556752 , @ngraham 
wrote:
  > >
  > > > In D25055#556751 , @mart 
wrote:
  > > >
  > > > > I would prefer keeping the press to move stuff
  > > >
  > > >
  > > > As far as I could tell, the option on this page doesn't actually change 
anything anymore. What am I missing?
  > >
  > >
  > > it makes the handles appear on mouse over, like they did in kde4, i spent 
a lot of time to make that work in the new layout
  >
  >
  > Can you be specific about how the behavior gets invoked? For me, when not 
in edit mode, the handles now always appear on hover, while outside of edit 
mode, the handles now only appear on press-and-hold. None of this changes 
regardless of whether or not the press-and-hold setting in Tweaks is checked.
  
  
  here they do appear on hover and delay

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma, hein
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Nathaniel Graham]

ngraham added a comment.


  In D25055#556755 , @mart wrote:
  
  > In D25055#556752 , @ngraham 
wrote:
  >
  > > In D25055#556751 , @mart wrote:
  > >
  > > > I would prefer keeping the press to move stuff
  > >
  > >
  > > As far as I could tell, the option on this page doesn't actually change 
anything anymore. What am I missing?
  >
  >
  > it makes the handles appear on mouse over, like they did in kde4, i spent a 
lot of time to make that work in the new layout
  
  
  Can you be specific about how the behavior gets invoked? For me, when not in 
edit mode, the handles now always appear on hover, while outside of edit mode, 
the handles now only appear on press-and-hold. None of this changes regardless 
of whether or not the press-and-hold setting in Tweaks is checked.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma, hein
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Marco Martin]

mart added a comment.


  In D25055#556756 , @GB_2 wrote:
  
  > I wonder, can that be added to mouse actions instead of a page with only 
one option?
  
  
  makes sense

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma, hein
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Björn Feber]

GB_2 added a comment.


  I wonder, can that be added to mouse actions instead of a page with only one 
option?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma, hein
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Marco Martin]

mart added a comment.


  In D25055#556752 , @ngraham wrote:
  
  > In D25055#556751 , @mart wrote:
  >
  > > I would prefer keeping the press to move stuff
  >
  >
  > As far as I could tell, the option on this page doesn't actually change 
anything anymore. What am I missing?
  
  
  it makes the handles appear on mouse over, like they did in kde4, i spent a 
lot of time to make that work in the new layout

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma, hein
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Björn Feber]

GB_2 added a comment.


  In D25055#556751 , @mart wrote:
  
  > I would prefer keeping the press to move stuff
  
  
  Is there a reason to disable it?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma, hein
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Marco Martin]

mart added a comment.


  I would prefer keeping the press to move stuff

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma, hein
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Nathaniel Graham]

ngraham marked an inline comment as done.
ngraham added a comment.


  In D25055#556751 , @mart wrote:
  
  > I would prefer keeping the press to move stuff
  
  
  As far as I could tell, the option on this page doesn't actually change 
anything anymore. What am I missing?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma, hein
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Nathaniel Graham]

ngraham marked an inline comment as done.
ngraham added inline comments.

INLINE COMMENTS

> broulik wrote in main.qml:268
> A conf update isn't needed as it's this code hiding the toolbox when 
> disabled, so without it it will just always show

Ah of course!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma, hein
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Kai Uwe Broulik]

broulik added a comment.


  +1

INLINE COMMENTS

> main.qml:268
> -property: "visible"
> -value: plasmoid.configuration.showToolbox
> -}

A conf update isn't needed as it's this code hiding the toolbox when disabled, 
so without it it will just always show

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Nathaniel Graham]

ngraham added a comment.


  It occurs to me that we'll need a kconf update script to turn the desktop 
toolbox back on for all the legions of people who turned off via this setting 
that I'm removing here, or else the new global edit mode won't work for them.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25055

To: ngraham, mart, GB_2, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25055: [containments/desktop] Delete the "Tweaks" page and its options

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: mart, GB_2, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  With the new global edit mode, both of the options on the Tweaks page become 
unnecessary:
  
  - The option to hide the toolbox becomes dangerous because it breaks global 
edit mode
  - The option to toggle press-and-hold does nothing because we always use 
press-and-hold

TEST PLAN
  - Right-click desktop > Configure Desktop > No "Tweaks" page at the bottom of 
the list: F7687032: No Tweaks.png 
  - Widget moving, resizing, and editing behaviors in side and out of edit mode 
are unchanged
  - You can no longer turn off the toolbox and break edit mode
  - You can no longer uselessly toggle the press-and-hold checkbox that has no 
effect

REPOSITORY
  R119 Plasma Desktop

BRANCH
  delete-tweaks-page (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25055

AFFECTED FILES
  containments/desktop/package/contents/config/config.qml
  containments/desktop/package/contents/config/main.xml
  containments/desktop/package/contents/ui/ConfigTweaks.qml
  containments/desktop/package/contents/ui/main.qml

To: ngraham, mart, GB_2, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart