D25100: Mark all wallpaper plugins as addons

ngraham added a comment. In D25100#592375 , @mak wrote: > @ngraham Did this have AppStream metadata before? Probably the distribution data still lists this as component, while the new file lists it as addon. The distro data is preferred, so

D25100: Mark all wallpaper plugins as addons

mak added a comment. Did this have AppStream metadata before? Probably the distribution data still lists this as component, while the new file lists it as addon. The distro data is preferred, so that's why this shows up as app. You need your distro to ship this as update, or set

D25100: Mark all wallpaper plugins as addons

ngraham abandoned this revision. ngraham added a comment. Seems like this isn't the right way to solve the problem. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25100 To: ngraham, apol, mak, #plasma Cc: davidre, davidedmundson, plasma-devel, LeGast00n,

D25100: Mark all wallpaper plugins as addons

apol added a comment. > But the distro-provided version (openSUSE Tumbleweed) does not: Yes, this happens because distros don't take plasma-workspace as a dependency, but in your computer you do have plasma-workspace installed. REPOSITORY R114 Plasma Addons REVISION DETAIL

D25100: Mark all wallpaper plugins as addons

ngraham added a comment. In D25100#557494 , @apol wrote: > One thing we could do is update this patch to have `X-KDE-ParentApp=org.kde.plasmashell` instead of the .plasma (which I'm pretty sure it doesn't make a difference, you can check by

D25100: Mark all wallpaper plugins as addons

apol added a comment. I just looked into it, the problem is that `plasma_packagestructure_wallpaper.so` is installed by plasma-workspace, which isn't a dependency of kdeplasma-addons. One thing we could do is update this patch to have `X-KDE-ParentApp=org.kde.plasmashell` instead of

D25100: Mark all wallpaper plugins as addons

apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. Yes, it's the wrong fix. For reference, it's not about discover, it's about generating the appstream file properly. Will try to provide a patch next week. REPOSITORY R114

D25100: Mark all wallpaper plugins as addons

davidre added a comment. I don't know how Discover works but to me looks the wrong fix. Does every third party wallpaper then also need to have a name with plasma in it? In my opinion ServiceType Plasma/Wallpaper should be enough for a Service as add-on and not having plasma in it's name.

D25100: Mark all wallpaper plugins as addons

ngraham added a comment. Hmm so if this is the correct solution to the indicated problem, I guess we would need a kconf update script to change the IDs in `plasma-org.kde.plasma.desktop-appletsrc`? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25100 To:

D25100: Mark all wallpaper plugins as addons

davidedmundson added a comment. What happens if a user has their setup to use potd or hunyango and we change this ID? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25100 To: ngraham, apol, mak, #plasma Cc: davidedmundson, plasma-devel, LeGast00n,

D25100: Mark all wallpaper plugins as addons

ngraham created this revision. ngraham added reviewers: apol, mak, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Heanau, Hunyango, and POTD wallpaper plugins still show up in Discover as apps because