D25104: Fix PageRow globalToolBar documentation

2019-11-02 Thread Dimitris Kardarakos 
dkardarakos added a comment.


  In D25104#557851 , @ahiemstra 
wrote:
  
  > Great, thank you!
  
  
  It was nothing!

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25104

To: dkardarakos, ognarb, ahiemstra
Cc: ahiemstra, ognarb, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, davidedmundson, mart, hein

D25104: Fix PageRow globalToolBar documentation

2019-11-02 Thread Dimitris Kardarakos 
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:c504f1327e5e: Fix PageRow globalToolBar documentation 
(authored by dkardarakos).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25104?vs=69185=69196

REVISION DETAIL
  https://phabricator.kde.org/D25104

AFFECTED FILES
  src/controls/PageRow.qml

To: dkardarakos, ognarb, ahiemstra
Cc: ahiemstra, ognarb, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, davidedmundson, mart, hein

D25104: Fix PageRow globalToolBar documentation

2019-11-02 Thread Arjen Hiemstra 
ahiemstra accepted this revision.
ahiemstra added a comment.


  Great, thank you!

REPOSITORY
  R169 Kirigami

BRANCH
  fix-pagerow-doc (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25104

To: dkardarakos, ognarb, ahiemstra
Cc: ahiemstra, ognarb, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, davidedmundson, mart, hein

D25104: Fix PageRow globalToolBar documentation

2019-11-02 Thread Dimitris Kardarakos 
dkardarakos added a comment.


  More fixes 
  F7716989: after_2.png 

REPOSITORY
  R169 Kirigami

BRANCH
  fix-pagerow-doc (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25104

To: dkardarakos, ognarb
Cc: ahiemstra, ognarb, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, davidedmundson, mart, hein

D25104: Fix PageRow globalToolBar documentation

2019-11-02 Thread Dimitris Kardarakos 
dkardarakos updated this revision to Diff 69185.
dkardarakos added a comment.


  Fix globalToolBar documentation
  
  Ensure that the documentation of each property of the globalToolBar group 
property is presented correctly

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25104?vs=69154=69185

BRANCH
  fix-pagerow-doc (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25104

AFFECTED FILES
  src/controls/PageRow.qml

To: dkardarakos, ognarb
Cc: ahiemstra, ognarb, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, davidedmundson, mart, hein

D25104: Fix PageRow globalToolBar documentation

2019-11-01 Thread Arjen Hiemstra 
ahiemstra added a comment.


  Can you also have a look at the height and reservedSpace properties below it? 
Those have similar issues.

REPOSITORY
  R169 Kirigami

BRANCH
  fix-pagerow-doc (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25104

To: dkardarakos, ognarb
Cc: ahiemstra, ognarb, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, davidedmundson, mart, hein

D25104: Fix PageRow globalToolBar documentation

2019-11-01 Thread Carl Schwan 
ognarb accepted this revision.
ognarb added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R169 Kirigami

BRANCH
  fix-pagerow-doc (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25104

To: dkardarakos, ognarb
Cc: ognarb, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart, hein

D25104: Fix PageRow globalToolBar documentation

2019-11-01 Thread Dimitris Kardarakos 
dkardarakos added a comment.


  Before
  F7709694: before.png 
  
  After
  F7709700: after.png 

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25104

To: dkardarakos
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25104: Fix PageRow globalToolBar documentation

2019-11-01 Thread Dimitris Kardarakos 
dkardarakos created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
dkardarakos requested review of this revision.

REVISION SUMMARY
  In PageRow documentation, globalToolBar's style contains an unordered list of 
the various style value options. With this commit, the list is properly 
displayed.

REPOSITORY
  R169 Kirigami

BRANCH
  fix-pagerow-doc (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25104

AFFECTED FILES
  src/controls/PageRow.qml

To: dkardarakos
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein