D25191: replace bespoke xkb geometry parser with xkb

2019-11-28 Thread Harald Sitter
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:c7a1f606ca96: replace bespoke xkb geometry parser with xkb (authored by sitter). CHANGED PRIOR TO COMMIT

D25191: replace bespoke xkb geometry parser with xkb

2019-11-15 Thread Harald Sitter
sitter updated this revision to Diff 69799. sitter added a comment. - remove all color mapping tech, it's pointless since the code now uses the system palette - remove garbage foobar class - remove unnecessary main.moc include - create two global SystemPalettes instead of in individual

D25191: replace bespoke xkb geometry parser with xkb

2019-11-14 Thread David Redondo
davidre added a comment. Is the FooBar class for testing? I don't see it used anywhere. (and would guess soofrom the name) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25191 To: sitter, #plasma Cc: davidre, ngraham, plasma-devel, LeGast00n,

D25191: replace bespoke xkb geometry parser with xkb

2019-11-14 Thread Harald Sitter
sitter updated this revision to Diff 69752. sitter added a comment. - bump preview size a bit - update documentation - resolve outstanding todos REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25191?vs=69747=69752 BRANCH master REVISION

D25191: replace bespoke xkb geometry parser with xkb

2019-11-14 Thread Harald Sitter
sitter updated this revision to Diff 69747. sitter added a comment. - document why section overlays aren't modelled - doodad qml item creation is now type based rather than duck typed - logo doodads are now supported as a compositie of shape doodads and labels - outline doodads now

D25191: replace bespoke xkb geometry parser with xkb

2019-11-08 Thread Nathaniel Graham
ngraham added a comment. Oh so much faster now. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25191 To: sitter, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai,

D25191: replace bespoke xkb geometry parser with xkb

2019-11-08 Thread Harald Sitter
sitter updated this revision to Diff 69441. sitter added a comment. fix tooltip scaling to show keys at 2.5 times their original size REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25191?vs=69437=69441 BRANCH master REVISION DETAIL

D25191: replace bespoke xkb geometry parser with xkb

2019-11-08 Thread Harald Sitter
sitter updated this revision to Diff 69437. sitter added a comment. install bin, drop ki18n as link target (not used at this time) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25191?vs=69388=69437 BRANCH master REVISION DETAIL

D25191: replace bespoke xkb geometry parser with xkb

2019-11-07 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY the bespoke parser was a horrendous drain on the build time of plasma-desktop due to recursive