D25324: [GTK Config] Add XSettingsd as a runtime dependency

2020-03-10 Thread Mikhail Zolotukhin
gikari closed this revision.
gikari added a comment.


  https://phabricator.kde.org/R99:b6e7c6f056740e936adc94b7a843f6448f6830ab

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D25324

To: gikari, #plasma, cblack, apol, jgrulich, ngraham
Cc: cfeck, jriddell, ngraham, eszlari, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart


D25324: [GTK Config] Add XSettingsd as a runtime dependency

2020-03-10 Thread Jonathan Riddell
jriddell added a comment.


  I don't think this is adding a new dependency just highlighting that there is 
one, so it's good to add to stable branches

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  xsettingsd-dependency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25324

To: gikari, #plasma, cblack, apol, jgrulich, ngraham
Cc: cfeck, jriddell, ngraham, eszlari, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart


D25324: [GTK Config] Add XSettingsd as a runtime dependency

2020-03-08 Thread Nathaniel Graham
ngraham added subscribers: jriddell, cfeck.
ngraham added a comment.


  We can't add a new required dependency since dependencies are frozen in the 
stable branches. Not sure what the policy is regarding adding optional ones 
though. @cfeck/@jriddell?

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  xsettingsd-dependency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25324

To: gikari, #plasma, cblack, apol, jgrulich, ngraham
Cc: cfeck, jriddell, ngraham, eszlari, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart


D25324: [GTK Config] Add XSettingsd as a runtime dependency

2020-03-08 Thread Mikhail Zolotukhin
gikari added a comment.


  Ok. So, can I land it or should I wait for other reviewers? Also, should I 
make the dependency `REQUIRED` or leave it optional?

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  xsettingsd-dependency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25324

To: gikari, #plasma, cblack, apol, jgrulich, ngraham
Cc: ngraham, eszlari, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart


D25324: [GTK Config] Add XSettingsd as a runtime dependency

2020-03-08 Thread Peter Eszlari
eszlari added a comment.


  In D25324#624299 , @gikari wrote:
  
  > In D25324#624229 , @eszlari 
wrote:
  >
  > > This bug is not fixed by this patch. `xsettingsd` needs to be started in 
`plasma-workspace/startkde/startplasma.cpp` (or by systemd in the future).
  >
  >
  > `xsettingsd` is started by the daemon itself, if it's not instantiated 
already. The daemon itself launches at startup, because it is a kded module.
  
  
  You are right, sorry for the noise! I must have mixed up someting while 
testing it on the Kubuntu 20.04 preview.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  xsettingsd-dependency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25324

To: gikari, #plasma, cblack, apol, jgrulich, ngraham
Cc: ngraham, eszlari, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart


D25324: [GTK Config] Add XSettingsd as a runtime dependency

2020-03-08 Thread Mikhail Zolotukhin
gikari added a comment.


  In D25324#624229 , @eszlari wrote:
  
  > This bug is not fixed by this patch. `xsettingsd` needs to be started in 
`plasma-workspace/startkde/startplasma.cpp` (or by systemd in the future).
  
  
  `xsettingsd` is started by the daemon itself, if it's not instantiated 
already.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  xsettingsd-dependency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25324

To: gikari, #plasma, cblack, apol, jgrulich, ngraham
Cc: ngraham, eszlari, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart


D25324: [GTK Config] Add XSettingsd as a runtime dependency

2020-03-08 Thread Peter Eszlari
eszlari added a comment.


  > BUG: 418263
  
  This bug is not fixed by this patch. `xsettingsd` needs to be started in 
`plasma-workspace/startkde/startplasma.cpp` (or by systemd in the future).
  
  > FIXED-IN: 5.19
  
  I would be nice, if this could make it to 5.18, so that `xsettingsd` would 
end up on the Kubuntu 20.04 ISO image (https://phabricator.kde.org/T12753).

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  xsettingsd-dependency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25324

To: gikari, #plasma, cblack, apol, jgrulich, ngraham
Cc: ngraham, eszlari, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart


D25324: [GTK Config] Add XSettingsd as a runtime dependency

2020-03-08 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Very nice.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  xsettingsd-dependency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25324

To: gikari, #plasma, cblack, apol, jgrulich, ngraham
Cc: ngraham, eszlari, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart


D25324: [GTK Config] Add XSettingsd as a runtime dependency

2020-03-07 Thread Mikhail Zolotukhin
gikari added a comment.


  Ping!

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D25324

To: gikari, #plasma, cblack, apol, jgrulich
Cc: eszlari, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart