This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d0fffa46372c: [KCMs/Workspace] Add explanatory labels for
click-related settings (authored by ngraham).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
Fuchs accepted this revision.
Fuchs added a comment.
This revision is now accepted and ready to land.
Good for me, hopefully the upstream bug will be fixed, too :)
REPOSITORY
R119 Plasma Desktop
BRANCH
explanatory-text (branched from master)
REVISION DETAIL
ngraham added a comment.
Ping.
If nobody likes this, I can just abandon it, but I'd appreciate some feedback
one way or another. :)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D25873
To: ngraham, #vdg, #plasma, Fuchs
Cc: davidedmundson, ndavis,
ngraham updated this revision to Diff 71340.
ngraham added a comment.
Add comment about the Qt situation
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25873?vs=71337=71340
BRANCH
explanatory-text (branched from master)
REVISION DETAIL
ngraham updated this revision to Diff 71337.
ngraham added a comment.
...and elide
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25873?vs=71336=71337
BRANCH
explanatory-text (branched from master)
REVISION DETAIL
ngraham updated this revision to Diff 71336.
ngraham marked an inline comment as done.
ngraham added a comment.
Fill width
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25873?vs=71328=71336
BRANCH
explanatory-text (branched from master)
davidedmundson added a comment.
It's not a common pattern we do in plasma currently, but that doesn't
necessarily mean we shouldn't use it.
INLINE COMMENTS
> main.qml:131
>
> +QQC2.Label {
> +text: singleClick.checked ? i18n("Select by clicking on item's
> selection
Fuchs added a comment.
Sidenote, maybe an upstream bug / wish can be added about
> Oh darn, so it does. I checked the docs and tried setting
SH_ScrollBar_MiddleClickAbsolutePosition explicitly, but it looks like there's
actually no option to do page-by-page navigation for clicking
ngraham updated this revision to Diff 71328.
ngraham added a comment.
Only show the message when left-click-navigates-by-page mode is in use
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25873?vs=71250=71328
BRANCH
explanatory-text (branched
ngraham added inline comments.
INLINE COMMENTS
> ndavis wrote in main.qml:164
> This is incorrect. Middle clicking still jumps to the clicked location.
Oh darn, so it does. I checked the docs and tried setting
`SH_ScrollBar_MiddleClickAbsolutePosition` explicitly, but it looks like
there's
ndavis added inline comments.
INLINE COMMENTS
> main.qml:164
> +QQC2.Label {
> +text: scrollbarLeftClickNavigatesByPage.checked ?
> i18n("Middle-click to scroll to clicked location") : i18n("Middle-click to
> scroll by page")
> +font.pointSize:
ngraham created this revision.
ngraham added reviewers: VDG, Plasma, Fuchs.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
This way the behavior of the related action is clear no matter which setting
is
12 matches
Mail list logo
