D25874: [Task Manager] Consider parent PID for audio stream

2019-12-19 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:09a258a22ed4: [Task Manager] Consider parent PID for 
audio stream (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25874?vs=71251=71844

REVISION DETAIL
  https://phabricator.kde.org/D25874

AFFECTED FILES
  CMakeLists.txt
  applets/taskmanager/CMakeLists.txt
  applets/taskmanager/package/contents/ui/PulseAudio.qml
  applets/taskmanager/plugin/backend.cpp
  applets/taskmanager/plugin/backend.h

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25874: [Task Manager] Consider parent PID for audio stream

2019-12-17 Thread Kai Uwe Broulik 
broulik added a comment.


  I have not. Given a browser window typically has dozens of children whereas 
you typically have few audio streams, I think if any it will be slower.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25874

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25874: [Task Manager] Consider parent PID for audio stream

2019-12-17 Thread Eike Hein 
hein added a comment.


  Just as a sanity check: libtm knows the pid for a window. Have you checked if 
there might be a faster way of doing this by checking if the stream pid is 
among its children?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25874

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25874: [Task Manager] Consider parent PID for audio stream

2019-12-11 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  For modern web browsers, the audio stream isn't owned by the same process as 
the window, making the mapping fail.
  When no PID is find for a window, check the streams, whether the PID might be 
actually the parent PID.

TEST PLAN
  - I get audio indicator on Chrome again

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25874

AFFECTED FILES
  CMakeLists.txt
  applets/taskmanager/CMakeLists.txt
  applets/taskmanager/package/contents/ui/PulseAudio.qml
  applets/taskmanager/plugin/backend.cpp
  applets/taskmanager/plugin/backend.h

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart