D25945: Sync dark theme preference for GTK3 applications

This revision was automatically updated to reflect the committed changes. Closed by commit R99:99c72b4b9581: Sync dark theme preference for GTK3 applications (authored by gikari). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D25945: Sync dark theme preference for GTK3 applications

ngraham added a comment. @apol is the maintainer and @broulik hasn't raised any objections, so I'd say you're good to go. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH sync-dark-gtk3-theme-preference REVISION DETAIL https://phabricator.kde.org/D25945 To: gikari, apol, cblack,

D25945: Sync dark theme preference for GTK3 applications

gikari added a comment. @broulik do I need your revision to land this? REPOSITORY R99 KDE Gtk Configuration Tool BRANCH sync-dark-gtk3-theme-preference REVISION DETAIL https://phabricator.kde.org/D25945 To: gikari, apol, cblack, broulik, #vdg Cc: GB_2, plasma-devel, LeGast00n,

D25945: Sync dark theme preference for GTK3 applications

gikari updated this revision to Diff 71806. gikari added a comment. Rebase on master REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25945?vs=71424=71806 BRANCH sync-dark-gtk3-theme-preference REVISION DETAIL

D25945: Sync dark theme preference for GTK3 applications

GB_2 added a comment. In D25945#577731 , @gikari wrote: > In D25945#577677 , @cblack wrote: > > > For flatpaks not respecting the setting preference, have you checked that the dark theme variant is

D25945: Sync dark theme preference for GTK3 applications

gikari added a comment. In D25945#577677 , @cblack wrote: > For flatpaks not respecting the setting preference, have you checked that the dark theme variant is installed? Yes, I have installed the theme. But after changing the value in

D25945: Sync dark theme preference for GTK3 applications

cblack accepted this revision. cblack added a comment. This revision is now accepted and ready to land. Code looks fine to me. For flatpaks not respecting the setting preference, have you checked that the dark theme variant is installed? f-d-o runtime doesn't offer an Adwaita-dark stub,

D25945: Sync dark theme preference for GTK3 applications

GB_2 added a comment. Works perfectly fine for me without waiting. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D25945 To: gikari, apol, cblack, broulik, #vdg Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen,

D25945: Sync dark theme preference for GTK3 applications

gikari created this revision. gikari added reviewers: apol, cblack, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Previously preference of dark GTK3 theme was set by checkbox in GTK KCM. Now, the