D26031: feat: access outputs controls through config control

[Roman Gilg]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:843baebaeb4e: feat: access outputs controls through 
config control (authored by romangg).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D26031?vs=71637=72167#toc

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26031?vs=71637=72167

REVISION DETAIL
  https://phabricator.kde.org/D26031

AFFECTED FILES
  common/control.cpp
  common/control.h

To: romangg, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26031: feat: access outputs controls through config control

[Roman Gilg]

romangg added a comment.


  In D26031#579232 , @davidedmundson 
wrote:
  
  > Why do we need to compare names as well as ID?
  
  
  The id is the output hash which can be either calculated from its name or 
edid. If you have two of the same output models that have the same edid you 
can't distinguish them. The name contains the port the output is connected with.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D26031

To: romangg, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26031: feat: access outputs controls through config control

[David Edmundson]

davidedmundson added a comment.


  Why do we need to compare names as well as ID?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D26031

To: romangg, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26031: feat: access outputs controls through config control

[Roman Gilg]

romangg created this revision.
romangg added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  Compositing output controls for all outputs into config control objects allows
  writing and reading values according to the retention setting.

TEST PLAN
  Compiles.

REPOSITORY
  R104 KScreen

BRANCH
  config-outputs-controls

REVISION DETAIL
  https://phabricator.kde.org/D26031

AFFECTED FILES
  common/control.cpp
  common/control.h

To: romangg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart