frenzie added inline comments.
INLINE COMMENTS
> PopupDialog.qml:73
> KeyNavigation.backtab: batteryList
> +stepSize: batterymonitor.maximumScreenBrightness/100
> +
Because it's artificially limited to 100 positions, this change makes it
impossible to set a value by
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:62be85f4360d: battery: Improve the brightness
responsiveness (authored by apol).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26035?vs=71743=72439
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.
Seems to work well, thanks
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26035
To: apol, #plasma, broulik
Cc: plasma-devel,
apol added a comment.
https://phabricator.kde.org/D26035 has been landed.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D26035
To: apol, #plasma, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas,
GB_2, ragreen,
apol marked an inline comment as done.
apol added inline comments.
INLINE COMMENTS
> broulik wrote in logic.js:53
> Wouldn't that cause subsequent calls to fail if the previous hasn't finished
> yet? Wouldn't that be annoying if you drag the slider quickly?
No, it will be called eventually,
apol updated this revision to Diff 71743.
apol added a comment.
Use a more meaningful step size for the screen. Having steps of 1 in a 1 to
7000 slider was awkward.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26035?vs=71643=71743
BRANCH
broulik added a comment.
`PlasmaComponents` 3 `Slider` doesn't react to wheel events, which must be
fixed before this can go in.
INLINE COMMENTS
> PopupDialog.qml:48
> -
> -keyboardBrightnessSlider.valueChanged.connect(function() {
> -batterymonitor.keyboardBrightness =
apol created this revision.
apol added reviewers: Plasma, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.
REVISION SUMMARY
Use QQC2.Slider, so that we have a moved signal. This way we can only
issue new brightnesses
