D26045: Add immutability to KCM Icons
This revision was automatically updated to reflect the committed changes. Closed by commit R119:097ad69d5e8b: Add immutability to KCM Icons (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26045?vs=71957=72448 REVISION DETAIL https://phabricator.kde.org/D26045 AFFECTED FILES kcms/icons/package/contents/ui/IconSizePopup.qml kcms/icons/package/contents/ui/main.qml To: bport, #plasma, ervin, ngraham, crossi, meven Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26045: Add immutability to KCM Icons
ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26045 To: bport, #plasma, ervin, ngraham, crossi, meven Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26045: Add immutability to KCM Icons
ngraham added a comment. Needs a rebase REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26045 To: bport, #plasma, ervin, ngraham, crossi, meven Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26045: Add immutability to KCM Icons
bport added inline comments. INLINE COMMENTS > bport wrote in main.qml:55 > Problem with this solution it will disable also icon size components, and we > don't want that, if you have a nicer solution my bad missread indeed view.enabled do what I want REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26045 To: bport, #plasma, ervin, ngraham, crossi, meven Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26045: Add immutability to KCM Icons
bport updated this revision to Diff 71957. bport added a comment. Take in consideration broulik feedback REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26045?vs=71672=71957 REVISION DETAIL https://phabricator.kde.org/D26045 AFFECTED FILES kcms/icons/package/contents/ui/IconSizePopup.qml kcms/icons/package/contents/ui/main.qml To: bport, #plasma, ervin, ngraham, crossi, meven Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26045: Add immutability to KCM Icons
bport added inline comments. INLINE COMMENTS > broulik wrote in main.qml:38 > Why this change? my bad, need to keep the downloaded stuff there > broulik wrote in main.qml:55 > Shouldn't this be set on the grid view then, i.e. the `view.enabled` stuff > Marco fixed a while back? Problem with this solution it will disable also icon size components, and we don't want that, if you have a nicer solution REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26045 To: bport, #plasma, ervin, ngraham, crossi, meven Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26045: Add immutability to KCM Icons
crossi added inline comments. INLINE COMMENTS > broulik wrote in main.qml:55 > Shouldn't this be set on the grid view then, i.e. the `view.enabled` stuff > Marco fixed a while back? Yes it should. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26045 To: bport, #plasma, ervin, ngraham, crossi, meven Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26045: Add immutability to KCM Icons
broulik added inline comments.
INLINE COMMENTS
> main.qml:38
> view.currentIndex: kcm.pluginIndex(kcm.iconsSettings.theme)
> -enabled: !kcm.downloadingFile
>
Why this change?
> main.qml:55
>
> +enabled: !kcm.iconsSettings.isImmutable("Theme") // don't allow to
> change theme if immutable, but allow to change icon sizes
> +
Shouldn't this be set on the grid view then, i.e. the `view.enabled` stuff
Marco fixed a while back?
> main.qml:230
> QtControls.Button {
> +enabled: true
> id: iconSizesButton
This is the default
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D26045
To: bport, #plasma, ervin, ngraham, crossi, meven
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26045: Add immutability to KCM Icons
bport created this revision. bport added reviewers: Plasma, ervin, ngraham, crossi, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REVISION SUMMARY Add immutability to KCM Icons, disable theme delegate and not the whole grid in order to allow user to change icon size if not immutable too TEST PLAN Add [$i] to kdeglobals key REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26045 AFFECTED FILES kcms/icons/package/contents/ui/IconSizePopup.qml kcms/icons/package/contents/ui/main.qml To: bport, #plasma, ervin, ngraham, crossi, meven Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
