D26049: [KCM/NightColor] Allow the user to know the default settings are selected
meven added a comment. FYI the restore button is currently always enabled on load even if parameters represent the default ones. I have a fix proposal at : https://phabricator.kde.org/D26085 REPOSITORY R119 Plasma Desktop BRANCH nightcolor-default REVISION DETAIL https://phabricator.kde.org/D26049 To: meven, #kwin, crossi, ervin, romangg, davidedmundson Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26049: [KCM/NightColor] Allow the user to know the default settings are selected
This revision was automatically updated to reflect the committed changes. Closed by commit R119:f1943a1e59ff: [KCM/NightColor] Allow the user to know the default settings are selected (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26049?vs=71795=71796 REVISION DETAIL https://phabricator.kde.org/D26049 AFFECTED FILES kcms/nightcolor/package/contents/ui/LocationsFixedView.qml kcms/nightcolor/package/contents/ui/main.qml To: meven, #kwin, crossi, ervin, romangg, davidedmundson Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26049: [KCM/NightColor] Allow the user to know the default settings are selected
meven updated this revision to Diff 71795. meven added a comment. Add a space for form REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26049?vs=71792=71795 BRANCH nightcolor-default REVISION DETAIL https://phabricator.kde.org/D26049 AFFECTED FILES kcms/nightcolor/package/contents/ui/LocationsFixedView.qml kcms/nightcolor/package/contents/ui/main.qml To: meven, #kwin, crossi, ervin, romangg, davidedmundson Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26049: [KCM/NightColor] Allow the user to know the default settings are selected
meven updated this revision to Diff 71792. meven marked an inline comment as done. meven added a comment. Split REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26049?vs=71790=71792 BRANCH nightcolor-default REVISION DETAIL https://phabricator.kde.org/D26049 AFFECTED FILES kcms/nightcolor/package/contents/ui/LocationsFixedView.qml kcms/nightcolor/package/contents/ui/main.qml To: meven, #kwin, crossi, ervin, romangg, davidedmundson Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26049: [KCM/NightColor] Allow the user to know the default settings are selected
davidedmundson accepted this revision. davidedmundson added inline comments. INLINE COMMENTS > main.qml:89 > +evenBeginManField.backend = cA.eveningBeginFixedDefault; > +transTimeField.value = cA.transitionTimeStaged = > cA.transitionTimeDefault; > Please split. REPOSITORY R119 Plasma Desktop BRANCH nightcolor-default REVISION DETAIL https://phabricator.kde.org/D26049 To: meven, #kwin, crossi, ervin, romangg, davidedmundson Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26049: [KCM/NightColor] Allow the user to know the default settings are selected
meven updated this revision to Diff 71790. meven added a comment. Remove unnecessary call REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26049?vs=71730=71790 BRANCH nightcolor-default REVISION DETAIL https://phabricator.kde.org/D26049 AFFECTED FILES kcms/nightcolor/package/contents/ui/LocationsFixedView.qml kcms/nightcolor/package/contents/ui/main.qml To: meven, #kwin, crossi, ervin, romangg Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26049: [KCM/NightColor] Allow the user to know the default settings are selected
romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Looks good to me. Maybe someone besides me who worked more recently on the KCM wants to give his ok as well. If nothing comes in till tomorrow, push. Thanks. REPOSITORY R119 Plasma Desktop BRANCH nightcolor-default REVISION DETAIL https://phabricator.kde.org/D26049 To: meven, #kwin, crossi, ervin, romangg Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26049: [KCM/NightColor] Allow the user to know the default settings are selected
meven updated this revision to Diff 71730. meven marked 2 inline comments as done. meven added a comment. Fix REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26049?vs=71725=71730 BRANCH nightcolor-default REVISION DETAIL https://phabricator.kde.org/D26049 AFFECTED FILES kcms/nightcolor/package/contents/ui/LocationsFixedView.qml kcms/nightcolor/package/contents/ui/main.qml To: meven, #kwin, crossi, ervin, romangg Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26049: [KCM/NightColor] Allow the user to know the default settings are selected
meven added inline comments. INLINE COMMENTS > romangg wrote in main.qml:65 > What is this supposed to do? Disable the restore default button REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26049 To: meven, #kwin, crossi, ervin, romangg Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26049: [KCM/NightColor] Allow the user to know the default settings are selected
romangg added inline comments.
INLINE COMMENTS
> main.qml:65
> +} else {
> +cA.nightColorAvailable = true;
> +}
What is this supposed to do?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D26049
To: meven, #kwin, crossi, ervin, romangg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas,
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26049: [KCM/NightColor] Allow the user to know the default settings are selected
meven updated this revision to Diff 71725. meven added a comment. Mark state as default when nightcolor is not available REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26049?vs=71715=71725 BRANCH nightcolor-default REVISION DETAIL https://phabricator.kde.org/D26049 AFFECTED FILES kcms/nightcolor/package/contents/ui/LocationsFixedView.qml kcms/nightcolor/package/contents/ui/main.qml To: meven, #kwin, crossi, ervin, romangg Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26049: [KCM/NightColor] Allow the user to know the default settings are selected
meven updated this revision to Diff 71715. meven added a comment. clean up diff REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26049?vs=71714=71715 BRANCH nightcolor-default REVISION DETAIL https://phabricator.kde.org/D26049 AFFECTED FILES kcms/nightcolor/package/contents/ui/LocationsFixedView.qml kcms/nightcolor/package/contents/ui/main.qml To: meven, #kwin, crossi, ervin, romangg Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26049: [KCM/NightColor] Allow the user to know the default settings are selected
meven updated this revision to Diff 71714. meven added a comment. [KCM/Access] Port to use KConfigXT REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26049?vs=71678=71714 BRANCH kaccess-kconfigxt REVISION DETAIL https://phabricator.kde.org/D26049 AFFECTED FILES kcms/access/CMakeLists.txt kcms/access/kaccess_settings.kcfg kcms/access/kaccess_settings.kcfgc kcms/access/kcmaccess.cpp kcms/nightcolor/package/contents/ui/LocationsFixedView.qml kcms/nightcolor/package/contents/ui/main.qml To: meven, #kwin, crossi, ervin, romangg Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26049: [KCM/NightColor] Allow the user to know the default settings are selected
meven created this revision. meven added reviewers: KWin, crossi, ervin, romangg. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. TEST PLAN kcmshell5 kcm_nightcolor Checked all settings reacts correctly to the restore defaults button REPOSITORY R119 Plasma Desktop BRANCH nightcolor-default REVISION DETAIL https://phabricator.kde.org/D26049 AFFECTED FILES kcms/nightcolor/package/contents/ui/LocationsFixedView.qml kcms/nightcolor/package/contents/ui/main.qml To: meven, #kwin, crossi, ervin, romangg Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
