D26052: KCM Cursor Theme : Use ManagedConfigModule

2019-12-26 Thread Benjamin Port 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:1e4271fb4cc3: KCM Cursor Theme : Use ManagedConfigModule 
(authored by bport).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26052?vs=71958=72191

REVISION DETAIL
  https://phabricator.kde.org/D26052

AFFECTED FILES
  kcms/cursortheme/cursorthemesettings.kcfgc
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h

To: bport, #plasma, ervin, crossi, ngraham
Cc: ngraham, meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26052: KCM Cursor Theme : Use ManagedConfigModule

2019-12-21 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Maybe next you can figure out what causes this bizarre behavior: F7828232: 
demo-2019-12-21_09.54.54.webm 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26052

To: bport, #plasma, ervin, crossi, ngraham
Cc: ngraham, meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26052: KCM Cursor Theme : Use ManagedConfigModule

2019-12-21 Thread Benjamin Port 
bport updated this revision to Diff 71958.
bport added a comment.


  Call ManagedConfiModule load/save/defaults parent method

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26052?vs=71681=71958

REVISION DETAIL
  https://phabricator.kde.org/D26052

AFFECTED FILES
  kcms/cursortheme/cursorthemesettings.kcfgc
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h

To: bport, #plasma, ervin, crossi
Cc: meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26052: KCM Cursor Theme : Use ManagedConfigModule

2019-12-17 Thread Cyril Rossi 
crossi added inline comments.

INLINE COMMENTS

> kcmcursortheme.cpp:367
>  {
>  m_settings->save();
> +setPreferredSize(m_settings->cursorSize());

Now you should simply call ManagedConfigModule::save(); instead

> kcmcursortheme.cpp:384
>  {
>  m_settings->load();
> +setPreferredSize(m_settings->cursorSize());

ManagedConfigModule::load();

> kcmcursortheme.cpp:403
>  {
>  m_settings->setDefaults();
>  m_preferredSize = m_settings->cursorSize();

ManagedConfigModule::defaults();

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26052

To: bport, #plasma, ervin, crossi
Cc: meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26052: KCM Cursor Theme : Use ManagedConfigModule

2019-12-16 Thread Méven Car 
meven resigned from this revision.
meven added a comment.
This revision now requires review to proceed.


  Looks good to me
  Someone from Plasma will be a better reviewer

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26052

To: bport, #plasma, ervin, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26052: KCM Cursor Theme : Use ManagedConfigModule

2019-12-16 Thread Benjamin Port 
bport created this revision.
bport added reviewers: Plasma, ervin, crossi, meven.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REVISION SUMMARY
  Use ManagedConfigModule instead of ConfigModule to remove uneeded code

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26052

AFFECTED FILES
  kcms/cursortheme/cursorthemesettings.kcfgc
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h

To: bport, #plasma, ervin, crossi, meven
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart